Fix linting complaints and update to v0.5.2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a conda-forge-webservices linter complaint ("License is not an SPDX identifier...") showing up as a check failure in PRs like conda-forge#6.
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
This fixes a linter complaint ("noarch: python recipes are required to have a lower bound on the python version") that's showing up in PRs like conda-forge#6.
I'm not sure if the python 3.2 lower bound is actually correct. The fredapi package's contents itself do not specify a minimum Python version in the documentation or metadata, as far as I can see. I selected 3.2 because that's the minimum version required by pandas 0.15, and the fredapi package does declare a 'pandas>=0.15' dependency in its requirements.txt.
…nda-forge-pinning 2024.05.31.10.10.48
apjanke
force-pushed
the
fix-linting-complaints-and-0.5.2
branch
from
6bcb77f to
1cd9d07
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
apjanke
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This should close the outstanding version bump PRs and bump-request issues:
Closes #6
Closes #5
Closes #4
This hopefully fixes the linter check falures that are causing the outstanding PRs for 0.5.2 and previous version bumps to fail their tests. Maybe that's what has prevented them from getting merged, and this PR will get an 0.5.2 upgrade going. We'd like to use fredapi 0.5.2 at our work because the current 0.4.2 version in this conda-forge package is not compatible with Python 3.11, due to a change in the xml package's API.
These are the outstanding PRs I see currently. I think getting this 0.5.2 upgrade through will make all of them moot.
I see them failing with the following linter complaints, which I believe this PR will fix: