-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebuild grpc 1.46.4 with abseil 20211102 #223
rebuild grpc 1.46.4 with abseil 20211102 #223
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Forget the rerender, it's just useless churn |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/grpc-cpp-feedstock/actions/runs/2868526465. |
My recommendation is to immediately revert this after merge. I can submit a follow up PR that essentially reverts this and bumps the build number. I think this is better for organization, but let me know what you prefer. |
Could it be that you confused yourself with the title and branch name? Because this is targetting 1.46.4 (which was also the point of #221), not 1.46.3 |
Yes! LOL. Don't tell anyone, but I was in a virtual doctor's appointment while doing this, hence the confusions... Let me run through everything again to ensure I am not losing my mind. |
I'm ready to merge this. Anything I should still be waiting for? |
I believe we are good to go, but since I have you here: I want to point out that abseil and grpc didn't get unzipped entirely. I thought they were supposed to be unzipped. Maybe I was wrong or misunderstood the latest abseil migration... xref: |
The plan is to unzip them after the 20220623 migration. @hmaarrfk was worried we'd run into more problems without the zip than with it. |
You can still override grpc on a per-feedstock level through the cbc; ping me in case of doubt. |
Okay, makes sense. Yes, it is safer this way. I also just read the migration file. Thanks! |
This reverts commit 006fe4d.
Follows #222
Fixes #221
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)