Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild grpc 1.46.4 with abseil 20211102 #223

Merged
merged 5 commits into from
Aug 16, 2022

Conversation

ngam
Copy link

@ngam ngam commented Aug 16, 2022

Follows #222
Fixes #221

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@ngam ngam changed the base branch from main to 1.46.x August 16, 2022 13:57
@ngam ngam closed this Aug 16, 2022
@ngam ngam reopened this Aug 16, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam
Copy link
Author

ngam commented Aug 16, 2022

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

Forget the rerender, it's just useless churn

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/grpc-cpp-feedstock/actions/runs/2868526465.

@ngam
Copy link
Author

ngam commented Aug 16, 2022

My recommendation is to immediately revert this after merge. I can submit a follow up PR that essentially reverts this and bumps the build number. I think this is better for organization, but let me know what you prefer.

@ngam ngam marked this pull request as ready for review August 16, 2022 14:04
@h-vetinari
Copy link
Member

Could it be that you confused yourself with the title and branch name? Because this is targetting 1.46.4 (which was also the point of #221), not 1.46.3

@ngam
Copy link
Author

ngam commented Aug 16, 2022

Could it be that you confused yourself with the title and branch name? Because this is targetting 1.46.4 (which was also the point of #221), not 1.46.3

Yes! LOL. Don't tell anyone, but I was in a virtual doctor's appointment while doing this, hence the confusions...

Let me run through everything again to ensure I am not losing my mind.

@ngam ngam changed the title rebuild grpc 1.46.3 with abseil 20211102 rebuild grpc 1.46.4 with abseil 20211102 Aug 16, 2022
@h-vetinari
Copy link
Member

Let me run through everything again to ensure I am not losing my mind.

I'm ready to merge this. Anything I should still be waiting for?

@ngam
Copy link
Author

ngam commented Aug 16, 2022

I believe we are good to go, but since I have you here: I want to point out that abseil and grpc didn't get unzipped entirely. I thought they were supposed to be unzipped. Maybe I was wrong or misunderstood the latest abseil migration...

xref:

@h-vetinari
Copy link
Member

I thought they were supposed to be unzipped. Maybe I was wrong or misunderstood the latest abseil migration...

The plan is to unzip them after the 20220623 migration. @hmaarrfk was worried we'd run into more problems without the zip than with it.

@h-vetinari
Copy link
Member

You can still override grpc on a per-feedstock level through the cbc; ping me in case of doubt.

@ngam
Copy link
Author

ngam commented Aug 16, 2022

I thought they were supposed to be unzipped. Maybe I was wrong or misunderstood the latest abseil migration...

The plan is to unzip them after the 20220623 migration. @hmaarrfk was worried we'd run into more problems without the zip than with it.

Okay, makes sense. Yes, it is safer this way. I also just read the migration file. Thanks!

@h-vetinari h-vetinari merged commit 006fe4d into conda-forge:1.46.x Aug 16, 2022
h-vetinari added a commit to hmaarrfk/grpc-cpp-feedstock that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants