Adding mvapich support #235

j34ni · 2024-10-23T14:16:15Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Here I tried to add MVAPIch support (latest version, regardless of the netmod, for now), keeping version 1.14.4 instead of moving to 1.14.5.

…nda-forge-pinning 2024.10.23.09.48.12

j34ni · 2024-10-23T14:16:31Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-23T14:18:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

recipe/conda_build_config.yaml

hmaarrfk · 2024-10-23T16:33:00Z

ping again if/when ready or you need help.

j34ni · 2024-10-23T16:35:59Z

@hmaarrfk Thanks, I will get in touch very soon then

j34ni · 2024-10-23T18:02:23Z

@hmaarrfk I think I got it working at least for linux-64/osx64/win, but there must be a need to update the patches for other platforms (osx-arm64, etc.)
Is this something you can help with?

hmaarrfk · 2024-10-23T18:23:57Z

unfortunately i do'nt have time. please see the other PRs where others have been working on something similar.

j34ni · 2024-10-26T07:13:56Z

@hmaarrfk Is it all good now?

hmaarrfk · 2024-10-26T11:23:30Z

recipe/dummy_t_filters_parallel.c

@@ -0,0 +1,6 @@
+#include <stdio.h>
+int main(void) {
+    printf("Replacement test for t_filters_parallel\n");


What do these test files do?

@hmaarrfk The t_filters_parallel test suite ensures the correct application and integrity of HDF5 filters, such as compression, in a parallel I/O context. The t_pmulti_dset test suite verifies the proper creation and I/O operations on multiple datasets in parallel. We had to disable these tests for MVAPICH due to specific failures for a couple of them, likely related to resource constraints in the testing environment.

Is there anything else needed from my side before this PR can be merged?

Can you add this statement as a comment in the source

recipe/build.sh

hmaarrfk · 2024-11-04T04:34:00Z

@conda-forge-admin please rerender

Please remember to bump the build number next time too!

Sorry i had to review how you "fixed" osx-arm. it seems you reverted to the older version

hmaarrfk · 2024-11-05T03:59:42Z

why did it magically start to fail?

hmaarrfk · 2024-11-05T04:00:27Z

you may unfortunately have to rebase: #239

conda-forge-admin · 2024-11-05T04:01:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk · 2024-11-05T04:02:48Z

i mostly just wanted to trigger a build

conda-forge-admin · 2024-11-05T07:42:01Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

j34ni · 2024-11-05T07:44:31Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-11-05T08:12:50Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk · 2024-11-05T09:54:23Z

hint: you must bump the build number again

j34ni · 2024-11-05T10:58:21Z

@hmaarrfk It seems that the build for the HDF5 package on Linux with MVAPICH was failing due to missing symbols related to libacl (which for some reason was not needed until now?!), and adding this package on the host resolved the issue, allowing the build to proceed successfully.
However there is now an issue with win64 and '".scripts\create_conda_build_artifacts.bat"' is not recognized as an internal or external command: did I mess up something else?

hmaarrfk · 2024-11-05T12:04:55Z

rebasing is etter than merging.

when you rebase, drop all the MNT commits from rerendering

j34ni · 2024-11-05T12:15:03Z

@conda-forge-admin, please rerender

j34ni · 2024-11-05T12:33:58Z

@hmaarrfk libacl is not required at runtime, only during the build, so I guess we can add;

  ignore_run_exports:
    - libacl

hmaarrfk · 2024-11-05T12:59:19Z

@hmaarrfk libacl is not required at runtime, only during the build, so I guess we can add;
  ignore_run_exports:
    - libacl

yes.

hmaarrfk · 2024-11-05T12:59:28Z

please add a comment referring to this PR.

j34ni · 2024-11-05T13:11:30Z

Or should I simply add it myself (I did not want to interrupt the build on Azure, which is now becoming all green)?

hmaarrfk · 2024-11-05T13:17:39Z

choose to interupt at your leisure or to let pass, but given this discussion, i'll wait until you you add the ignore run export and comment before we merge into main

hmaarrfk · 2024-11-05T13:18:01Z

if you have the git skills, it would be good to rebase this into a single commit + and a single rerender

Combined changes: - Removed valgrind - Update recipe/conda_build_config.yaml - Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com> - Moved --enable-tests=no - Use *_FOR_BUILD for MVAPIch as for OpenMPI - Revert to hdf5 version 1.14.4 and add mvapich support - Restored source for 1.14.4 - Skip t_pmulti_dset for MVAPIch - Restored hdf5_cv_szlib_can_encode=yes - Skip t_filters_parallel for MVAPIch - Including comment regarding t_filters_parallel and t_pmulti_dset tests - remove unecessary space - bump build number - do not store artifacts - Capture environment configuration - Update dummy_t_filters_parallel.c - Reverting to the commit which previously built - remove Libs.private from hdf5.pc on windows - Add reference - Address dynamic dependencies ensuring path alignment avoiding extraneous conflicts - Conditionally include libacl for Linux systems only - Bumped up build number - Restored .azure-pipelines/azure-pipelines-win.yml - Add ignore_run_exports to meta.yaml

j34ni · 2024-11-05T14:53:58Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-11-05T14:54:12Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-admin · 2024-11-05T14:56:54Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

…nda-forge-pinning 2024.11.05.14.14.53

github-actions · 2024-11-05T17:59:04Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

j34ni · 2024-11-05T18:02:03Z

Thanks @hmaarrfk
Now I just have to continue with NetCDF, etc.

MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.43.0, and co…

9116258

…nda-forge-pinning 2024.10.23.09.48.12

j34ni requested review from SylvainCorlay, astrofrog, davidbrochart, gillins, groutr, hmaarrfk, jakirkham, marcelotrevisani, ocefpaf, scopatz, varlackc and zklaus as code owners October 23, 2024 14:16

j34ni changed the title ~~Update to hdf5 1.14.5 and add mvapich support~~ Update to hdf5 1.14.5 and add mvapich support - Work in progress Oct 23, 2024

hmaarrfk reviewed Oct 23, 2024

View reviewed changes

recipe/conda_build_config.yaml Outdated Show resolved Hide resolved

hmaarrfk marked this pull request as draft October 23, 2024 16:32

j34ni changed the title ~~Update to hdf5 1.14.5 and add mvapich support - Work in progress~~ Keeping version hdf5 1.14.4 and adding mvapich support - Work in progress Oct 25, 2024

j34ni changed the title ~~Keeping version hdf5 1.14.4 and adding mvapich support - Work in progress~~ Keeping version hdf5 1.14.4 and adding mvapich support Oct 26, 2024

j34ni marked this pull request as ready for review October 26, 2024 07:14

hmaarrfk reviewed Oct 26, 2024

View reviewed changes

j34ni changed the title ~~Keeping version hdf5 1.14.4 and adding mvapich support~~ Adding mvapich support Oct 30, 2024

hmaarrfk reviewed Oct 30, 2024

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

conda-forge-webservices bot closed this Nov 5, 2024

conda-forge-webservices bot reopened this Nov 5, 2024

j34ni force-pushed the Update_to_hdf5-1.14.5_and_add_mvapich_support branch from aa0c7c9 to c7543bd Compare November 5, 2024 14:52

Merge branch 'main' into Update_to_hdf5-1.14.5_and_add_mvapich_support

f183246

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.43.2, and co…

5aef843

…nda-forge-pinning 2024.11.05.14.14.53

hmaarrfk added the automerge Merge the PR when CI passes label Nov 5, 2024

github-actions bot merged commit 0242148 into conda-forge:main Nov 5, 2024
23 checks passed

Adding mvapich support #235

Adding mvapich support #235

Conversation

j34ni commented Oct 23, 2024 • edited Loading

j34ni commented Oct 23, 2024

conda-forge-admin commented Oct 23, 2024

hmaarrfk commented Oct 23, 2024

j34ni commented Oct 23, 2024

j34ni commented Oct 23, 2024

hmaarrfk commented Oct 23, 2024

j34ni commented Oct 26, 2024

hmaarrfk Oct 26, 2024

Choose a reason for hiding this comment

j34ni Oct 26, 2024

Choose a reason for hiding this comment

j34ni Oct 30, 2024

Choose a reason for hiding this comment

hmaarrfk Oct 30, 2024

Choose a reason for hiding this comment

j34ni Oct 30, 2024

Choose a reason for hiding this comment

hmaarrfk commented Nov 4, 2024

hmaarrfk commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

conda-forge-admin commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

conda-forge-admin commented Nov 5, 2024

j34ni commented Nov 5, 2024

conda-forge-admin commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

j34ni commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

j34ni commented Nov 5, 2024

j34ni commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

j34ni commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

hmaarrfk commented Nov 5, 2024

j34ni commented Nov 5, 2024

conda-forge-admin commented Nov 5, 2024

conda-forge-admin commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

j34ni commented Nov 5, 2024

j34ni commented Oct 23, 2024 •

edited

Loading