Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build falgs for 2.1.0 #4

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Update build falgs for 2.1.0 #4

merged 4 commits into from
Nov 29, 2019

Conversation

t20100
Copy link
Contributor

@t20100 t20100 commented Nov 29, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR builds on PR #3 and updates the build options to:

@t20100
Copy link
Contributor Author

t20100 commented Nov 29, 2019

@conda-forge-admin, please rerender

@t20100
Copy link
Contributor Author

t20100 commented Nov 29, 2019

This PR is using the same build number as PR #3... Is it an issue?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@tschoonj
Copy link
Contributor

Looking good. Attached a commit that removes some extraneous lines in build.sh. Will merge in afterwards.

By the way would you like to be added as a maintainer?

@tschoonj tschoonj merged commit 0f1ebc4 into conda-forge:master Nov 29, 2019
@t20100 t20100 deleted the 2.1.0 branch November 29, 2019 14:29
@t20100
Copy link
Contributor Author

t20100 commented Nov 29, 2019

Yes, you can add me as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build flags for the next version of hdf5plugin
3 participants