Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipykernel 6.12.0 #124

Merged
merged 4 commits into from
Apr 4, 2022
Merged

ipykernel 6.12.0 #124

merged 4 commits into from
Apr 4, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Apr 4, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk added the automerge Merge the PR when CI passes label Apr 4, 2022
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 4, 2022

minrk added the automerge label now

i dunno, i have fear 😆

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 4, 2022

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ipykernel-feedstock/actions/runs/2089805403.

@minrk
Copy link
Member

minrk commented Apr 4, 2022

i dunno, i have fear

Bot's smart - it doesn't merge unless it's all green, and won't merge if you push new commits. It's just a handy way for me to say "merge if it's all green" which is what I was going to do anyway, so I don't have to wait and stare at the little orange circles.

@blink1073
Copy link
Member

Might want to hold off before adding new test deps: ipython/ipykernel#904

@minrk
Copy link
Member

minrk commented Apr 4, 2022

I really want to find a fix to allow this package to be noarch. Feels so silly to need all those platform builds just for the path in kernel.json.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 4, 2022

Bot's smart

oh, i know, but i sometimes watch these monster builds a little more closely... nothing like a ClobberWarning to ruin your day... but...

hold off before adding new test deps:

it passes, are we sad? seems to work.

allow this package to be noarch.

welp, we actually can now, as we can do multi-platform noarch builds:

https://conda-forge.org/docs/maintainer/conda_forge_yml.html?highlight=noarch_platforms#noarch-platforms

so basically we'd have an ipykernel that only worked on unix and one that worked on windows. i'll issue up...

Copy link
Contributor Author

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ can't approve my own, but LGTM, no further changes planned

@bollwyvl bollwyvl mentioned this pull request Apr 4, 2022
3 tasks
@minrk minrk merged commit 61e1433 into conda-forge:main Apr 4, 2022
@minrk
Copy link
Member

minrk commented Apr 4, 2022

Everything passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants