-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for pypy #55
Rebuild for pypy #55
Conversation
…nda-forge-pinning 2020.03.10
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
blocked by conda-forge/ipython-feedstock#100 |
Should rekick this once CDN updates... |
@conda-forge-admin please rerender.
|
…nda-forge-pinning 2020.03.20
Gah, the numpy stuff will complicate this. More concerning is the kernelspec not getting rewritten on windows, the whole reason this thing is not
then...
|
Seeing the the same in #56. |
I guess we need to look into whether one of the build/*prefix_files flags
will fix the kernel spec... It's plausible the escaped json isn't getting
picked up by the ripgrep pattern, but would be rewritten if we told cb
about it.
…On Sun, Mar 22, 2020, 09:51 Steven Silvester ***@***.***> wrote:
Seeing the the same in #56
<#56>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRCI7BZT4LFPC5HHTGLRIYJXZANCNFSM4LF6NYMQ>
.
|
The build vars didn't work, alas. The hack I've put up, which uses It may be worth considering adopting such a convention for paths-in-JSON upstream. |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
I guess we could pin
which seems comparable to what's on win ci:
|
Yeah, I'd say pin for now |
@@ -64,22 +64,22 @@ jobs: | |||
|
|||
- task: CondaEnvironment@1 | |||
inputs: | |||
packageSpecs: 'python=3.6 conda-build conda conda-forge::conda-forge-ci-setup=2' # Optional | |||
packageSpecs: 'python=3.6 conda-build=3.18.11 conda conda-forge::conda-forge-ci-setup=2' # Optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll see if this works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good sign:
Detected hard-coded path in text file share/jupyter/kernels/python3/kernel.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind applying this to #56 so we can get the release out?
course, it isn't going to fix our numpy issue, which i haven't even looked into... |
Ok, pinning worked... now what to do with numpy... i guess we can do some jinja stuff? i'll have to look into what's available, unless somebody has ideas. will also ping gitter. |
Merged #56, so once again will have to do a bunch of work to clean this up... sigh. |
…nda-forge-pinning 2020.03.24
having a look... |
recipe/run_test.py
Outdated
@@ -49,5 +52,10 @@ | |||
if sys.platform == "darwin": | |||
pytest_args += ["-k", "not (test_subprocess_error or test_subprocess_print)"] | |||
|
|||
# https://github.com/ipython/ipykernel/pull/496 | |||
if py_impl == "PyPy": | |||
pytest_args += ["-k", "not (test_io_api)"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that the test skip for |
🎉 |
CI is looking good, will leave this open for a day-ish for anybody to comment. Thanks @isuruf for keeping the ball rolling in the meantime... |
Let's go with it! |
Gah, one windows test flake... |
Should be possible to retrigger from the GitHub UI. |
for future reference: where? whitespace commit sorted it in the meantime:
|
If I do that with the merge commit of this PR, here's the page I get to. |
@jakirkham, can you send a PR to docs about this? |
Not atm, but please feel free to grab it. |
This PR has been triggered in an effort to update pypy.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/15006, please use this URL for debugging