Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot-automerge] jaxlib v0.1.76 #79

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Jan 27, 2022

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • flax
  • requests
  • typing_extensions
  • tensorflow-base
  • scikit-bio
  • tensorflow
  • tabulate
  • jax
  • opt_einsum

Packages found in the meta.yaml but not found by inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1757382123, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@xhochy
Copy link
Member

xhochy commented Feb 13, 2022

@conda-forge/help-osx-arm64 Any ideas why this fails with ERROR: jaxlib-0.1.76-cp310-none-macosx_11_0_arm64.whl is not a supported wheel on this platform.? I'm a bit confused also that locally $SP_DIR is completely empty. I thought we only delete the dylibs from there.

@erykoff
Copy link

erykoff commented Feb 13, 2022

So I don't know if this line:

${PYTHON} -m pip install dist/jaxlib-*.whl
works with cross-python. It's not a usage I've seen before, and it might be asking pip to install the arm64 wheel into an x86 env (because that's the only python that can run in cross-mode).

@erykoff
Copy link

erykoff commented Feb 13, 2022

Would adding something here with pip work?

  --platform <platform>       Only use wheels compatible with <platform>. Defaults to the
                              platform of the running system. Use this option multiple times
                              to specify multiple platforms supported by the target
                              interpreter.

@xhochy
Copy link
Member

xhochy commented Feb 13, 2022

So I don't know if this line:

${PYTHON} -m pip install dist/jaxlib-*.whl

works with cross-python. It's not a usage I've seen before, and it might be asking pip to install the arm64 wheel into an x86 env (because that's the only python that can run in cross-mode).

Yes, it tries to install it into the x86 environment. I'll try with going with unzip instead of pip here and see whether that works.

@erykoff
Copy link

erykoff commented Feb 13, 2022

Oh my, I just saw how long it takes to build this. Now that's going to create a long debug cycle!

@xhochy
Copy link
Member

xhochy commented Feb 13, 2022

Oh my, I just saw how long it takes to build this. Now that's going to create a long debug cycle!

Building this locally and working with the environments left behind of failed builds actually, gets this done in okish time.

@xhochy xhochy added the automerge Merge the PR when CI passes label Feb 13, 2022
@erykoff
Copy link

erykoff commented Feb 14, 2022

Good news is that the osx_arm64 builds seem to be working! Bad news is that it seems to have timed out/lost connection to one of the long linux builds...

@xhochy
Copy link
Member

xhochy commented Feb 14, 2022

Yeah, this vendors oneDNN, LLVM and protobuf and the mighty tensorflow. It would be nice to get at least one of the first three unvendored.

@xhochy
Copy link
Member

xhochy commented Feb 15, 2022

We can unvendor some libs but we need to the latest abseil-cpp: conda-forge/abseil-cpp-feedstock#24

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 15, 2022
@xhochy
Copy link
Member

xhochy commented Feb 16, 2022

I'm working locally on the osx-arm64 builds and Linux fails due to the use of std=c++14, we need std=c++17 for abseil-cpp.

2022-02-15T19:56:22.3781874Z INFO: Found applicable config definition build:posix in file /home/conda/feedstock_root/build_artifacts/jaxlib_1644954789833/work/.bazelrc: --copt=-fvisibility=hidden --copt=-Wno-sign-compare --cxxopt=-std=c++14 --host_cxxopt=-std=c++14

@xhochy
Copy link
Member

xhochy commented Feb 16, 2022

osx-arm64 needs conda-forge/bazel-toolchain-feedstock#7

@xhochy xhochy added the automerge Merge the PR when CI passes label Feb 17, 2022
@xhochy
Copy link
Member

xhochy commented Feb 17, 2022

The good news is that in the meanwhile the two patches I have added to the feedstock have been merged into Tensorflow and thus can be removed in a near-future release of jaxlib again.

@github-actions github-actions bot merged commit 75cab27 into conda-forge:master Feb 17, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.1.76_ha36163 branch February 17, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error Arm64 wheels are released! How to test for LLVM errors
4 participants