Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override CMake's platform-dependent CFLAGS #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hattne
Copy link

@hattne hattne commented Apr 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The need to build libarchive with /MD to use a multithreaded DLL runtime has been recognized before: the repository has 0009-CMake-Force-Multi-threaded-DLL-runtime.patch which adds /MD to the cl command line, but that patch is currently not applied. This PR addresses the problem by omitting CMAKE_C_FLAGS_RELEASE in the CMake invocation. CMake will then honor default flags for the platform (Modules\Platform\Windows-MSVC.cmake, in this case) in addition to CFLAGS from the environment.

This also means that NDEBUG will be defined for a release build, which, according to a comment in build_libarchive.dat will break the tests. However, the tests are disabled, and several of them fail, regardless of whether NDEBUG is defined or not. Defining NDEBUG seems inconsequential.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hattne hattne marked this pull request as ready for review April 26, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant