Do not override CMake's platform-dependent CFLAGS #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)The need to build
libarchive
with/MD
to use a multithreaded DLL runtime has been recognized before: the repository has0009-CMake-Force-Multi-threaded-DLL-runtime.patch
which adds/MD
to thecl
command line, but that patch is currently not applied. This PR addresses the problem by omittingCMAKE_C_FLAGS_RELEASE
in the CMake invocation. CMake will then honor default flags for the platform (Modules\Platform\Windows-MSVC.cmake
, in this case) in addition toCFLAGS
from the environment.This also means that
NDEBUG
will be defined for a release build, which, according to a comment inbuild_libarchive.dat
will break the tests. However, the tests are disabled, and several of them fail, regardless of whetherNDEBUG
is defined or not. DefiningNDEBUG
seems inconsequential.