-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to {{ stdlib("c") }}
#17
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin , please re-render |
@conda-forge-admin , please restart CI |
conda-forge.yml
Outdated
@@ -8,5 +8,7 @@ github: | |||
tooling_branch_name: main | |||
os_version: | |||
linux_64: cos7 | |||
linux_aarch64: cos7 | |||
linux_ppc64le: cos7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to drop linux_ppc64le
as this architecture is unsupported by this package
bdb9b50
to
749be4b
Compare
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.05.14.14.54.30
os_version: | ||
linux_64: cos7 | ||
linux_aarch64: cos7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variants for linux-64
are unchanged as that was already using CentOS 7
Similarly variants for linux-aarch64
are unchanged as this is the default
Plus conda-smithy was always adding c_stdlib
before ( conda-forge/conda-smithy#1888 ). Hence why those values are already filled out. Of course conda-smithy no longer adds c_stdlib
( conda-forge/conda-smithy#1908 ). Though as we add {{ stdlib("c") }}
in this PR, we keep it throughout
All this to say the changes here are working as expected even though the diff is a bit lighter
The
sysroot*
syntax is getting phased out (conda-forge/conda-forge.github.io#2102).The recommendation is to move to
{{ stdlib("c") }}
.Ref conda-forge/cuda-feedstock#26