Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to {{ stdlib("c") }} #17

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Apr 23, 2024

The sysroot* syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to {{ stdlib("c") }}.

Ref conda-forge/cuda-feedstock#26

@hcho3 hcho3 requested a review from a team as a code owner April 23, 2024 21:53
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham
Copy link
Member

@conda-forge-admin , please restart CI

conda-forge.yml Outdated
@@ -8,5 +8,7 @@ github:
tooling_branch_name: main
os_version:
linux_64: cos7
linux_aarch64: cos7
linux_ppc64le: cos7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to drop linux_ppc64le as this architecture is unsupported by this package

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Comment on lines 9 to +11
os_version:
linux_64: cos7
linux_aarch64: cos7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variants for linux-64 are unchanged as that was already using CentOS 7

Similarly variants for linux-aarch64 are unchanged as this is the default

Plus conda-smithy was always adding c_stdlib before ( conda-forge/conda-smithy#1888 ). Hence why those values are already filled out. Of course conda-smithy no longer adds c_stdlib ( conda-forge/conda-smithy#1908 ). Though as we add {{ stdlib("c") }} in this PR, we keep it throughout

All this to say the changes here are working as expected even though the diff is a bit lighter

@jakirkham jakirkham merged commit e99c61e into conda-forge:main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants