Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc3, forward port testing improvements, rebase pre-C11 fallbacks #129

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

h-vetinari
Copy link
Member

From #127; let's see how far back in clang we can go without the revert for C11.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari closed this Aug 12, 2023
@h-vetinari h-vetinari reopened this Aug 12, 2023
@h-vetinari h-vetinari changed the title Forward port testing improvements Forward port testing improvements, rebase pre-C11 fallbacks Aug 12, 2023
@h-vetinari h-vetinari marked this pull request as ready for review August 12, 2023 06:11
@h-vetinari
Copy link
Member Author

OK, without the revert of llvm/llvm-project@21f73d5, libcxx 17 fails with clang 12 and older.

I've rebased the revert now, but that was only feasible because the conflicts were trivial. If the conflicts become complicated, or the added tests for new libcxx plus a very old clang fail and we cannot salvage it easily, then that's IMO just something to accept and move on.

Given that libcxx 17 only officially supports clang 15-17, We're already more than doubling the upstream support here (3 -> 7 clang versions).

CC @conda-forge/libcxx

@h-vetinari h-vetinari changed the title Forward port testing improvements, rebase pre-C11 fallbacks rc3, forward port testing improvements, rebase pre-C11 fallbacks Aug 23, 2023
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 23, 2023
@github-actions github-actions bot merged commit 6884af9 into conda-forge:rc Aug 23, 2023
4 checks passed
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant