-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc3, forward port testing improvements, rebase pre-C11 fallbacks #129
Conversation
…nda-forge-pinning 2023.07.29.23.56.43
Add testing against older clangs on osx
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
OK, without the revert of llvm/llvm-project@21f73d5, libcxx 17 fails with clang 12 and older. I've rebased the revert now, but that was only feasible because the conflicts were trivial. If the conflicts become complicated, or the added tests for new libcxx plus a very old clang fail and we cannot salvage it easily, then that's IMO just something to accept and move on. Given that libcxx 17 only officially supports clang 15-17, We're already more than doubling the upstream support here (3 -> 7 clang versions). CC @conda-forge/libcxx |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
From #127; let's see how far back in clang we can go without the revert for C11.