-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve requirements #178
Improve requirements #178
Conversation
- depend on libcurl instead of curl to get right run_exports - add libaec dependency
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.07.03.12.03.06
…nda-forge-pinning 2023.07.03.12.03.06
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libnetcdf-feedstock/actions/runs/5444595782. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libnetcdf-feedstock/actions/runs/5446069775. |
…nda-forge-pinning 2023.07.03.13.49.19
…nda-forge-pinning 2023.07.04.06.34.52
…nda-forge-pinning 2023.07.04.14.14.08
Linux
OsxLike Linux, only different C++ runtime
WindowsSlightly worse with
I think the additional warnings come about because the checker doesn't know to include the hdf5 plugin dir in its consideration because it is not in the same library directory as the rest, in other words, I think these warnings are spurious. |
This comment was marked as outdated.
This comment was marked as outdated.
…nda-forge-pinning 2023.07.05.03.37.54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would certainly like someone with more expertise than me to have a look but this looks really excellent to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally reasonable to me.
Ok, 3 approvals is good enough :-) Thanks @zklaus for the awesome work you put into this! |
Cheers guys 😃 |
@zklaus is this now compiled with byte-range flag on? (sorry, didn't want to go through all the changed files haha). If so then this means we now have S3 support by my back-of-the-enevolope calculations? Many thanks, bud 🍺 |
Yes, @valeriupredoi, byte-range is available now. And I think you are right that this is enough for S3 access, particularly for single netcdf4 files. Though as I understand the discussion in #160 and #166, you may need to tell libnetcdf about it by appending something like |
Ooh nice thanks bud - am gonna reference your comment here to our issue, so I don't forget both the info and the references, it's getting a bit Google Map-y with all these issues and PRs. Cheers muchly 🍺 |
Checklist
Reset the build number to0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)The main goal of this PR is to sort out any overlinking-related warnings. The main tool for that is fixing any dependency irks. In the process, this is what came out:
curl
dependency withlibcurl
dependency, which also brings the right run_exportIt also aligns the Windows and Linux builds more closely by
BUILD_UTILITES=ON
ENABLE_DOXYGEN=OFF
ENABLE_DAP=ON
ENABLE_NETCDF_4=ON
ENABLE_PLUGIN_INSTALL=ON
ENABLE_BYTERANGE=ON