Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmdev 16.0.0.rc4 #201

Merged
merged 5 commits into from
Mar 15, 2023
Merged

llvmdev 16.0.0.rc4 #201

merged 5 commits into from
Mar 15, 2023

Conversation

h-vetinari
Copy link
Member

No description provided.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@h-vetinari
Copy link
Member Author

Interesting, something is causing ninja install in install_llvm.sh to repeat the full build from build.sh.

I remember that this happened before in clangdev, where this was caused/fixed by:

@isuruf: I marked as clang_bootstrap 11.rc builds as broken to avoid different compilers in top level build vs output level build envs which caused make to recompile.

This would seem to point to the merge of conda-forge/clang-compiler-activation-feedstock#91 as the culprit, but the compilers are actually the same between build.sh and the libllvm16 output:

build.sh:

    clang_bootstrap_osx-64: 14.0.6-h6ddedbb_4         conda-forge
    libcxx:                 14.0.6-hccf4f1f_0         conda-forge

libllvm16:

    clang_bootstrap_osx-64: 14.0.6-h6ddedbb_4         conda-forge
    libcxx:                 15.0.7-h71dddab_0         conda-forge

I'm not 100% if that's causing it, but what did stand out was a difference in the libcxx being pulled in (conda-forge/libcxx-feedstock#108 was merged after #198).

@isuruf, if you have an idea what's going on here, your input would be much appreciated.

@isuruf
Copy link
Member

isuruf commented Mar 12, 2023

Did you run a verbose ninja build?

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Mar 12, 2023
@h-vetinari
Copy link
Member Author

So ninja --verbose install doesn't give much more info (aside from spelling out the full call), it just starts recompiling immediately:

+ cd build
+ ninja --verbose install
[1/3315] /Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/_build_env/bin/arm64-apple-darwin20.0.0-clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/build/lib/Demangle -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/llvm/lib/Demangle -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/build/include -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/llvm/include -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem /Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work=/usr/local...
[2/3315] /Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/_build_env/bin/arm64-apple-darwin20.0.0-clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/build/lib/Demangle -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/llvm/lib/Demangle -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/build/include -I/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work/llvm/include -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem /Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/llvm-package_1678664749514/work=/usr/local...

(note I didn't shorten the lines; the ... at the end is how they appear in azure for osx-arm)

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Mar 14, 2023
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Mar 14, 2023
@h-vetinari h-vetinari merged commit 3b8690a into conda-forge:rc Mar 15, 2023
@h-vetinari h-vetinari deleted the rc branch March 15, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants