-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put mamba
under condabin/
too
#251
Conversation
Hi! This is the friendly automated conda-forge-linting service. I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub actions workflow run https://github.com/conda-forge/mamba-feedstock/actions/runs/11103975998. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @jaimergp.
recipe/build_mamba.bat
Outdated
|
||
:: Place mamba executable copy to condabin/ | ||
mkdir "%PREFIX%\condabin" | ||
echo ^"%LIBRARY_BIN%\mamba.exe^" %%* > "%PREFIX%\condabin\mamba.bat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I need to check but I'm pretty sure this would break the mamba acivate / mamba deactivate features (I am swamped with fixing micromamba activate now, I'll check that right after).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also place a copy of the full executable there. Would that break activation?
Back on this, these scripts should actually be generated via |
I think this should be part of the package itself. Some setups expect |
If the paths in.bat files are replaced when relocating packages, it should work and that should be the proper fix. |
The only |
CI now shows this for the
|
@jaimergp sorry for the long time before coming back to this! Thanks for the fix ;) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Some users have
$PREFIX/condabin
inPATH
, and updating to mamba 2.0 breaks their workflows because it's only putting the executable underbin/
, which results in errors likeexecutable not found
etc. See https://github.com/conda-incubator/setup-miniconda/actions/runs/11083642307/job/30798086717?pr=367#step:3:906.