Sync #47
Open
Sync #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. then symlink the non-wide filenames to them. From: http://www.linuxfromscratch.org/lfs/view/development/chapter06/ncurses.html "These wide-character libraries are usable in both multibyte and traditional 8-bit locales, while normal libraries work properly only in 8-bit locales" LFS use linker scripts instead of symlinks. Both work fine on Linux while symlinks also work on Darwin.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
isuruf
reviewed
Oct 31, 2018
| # consumers of ncurses and that is a very bad thing indeed. If we wanted to do that we would: | ||
| # export EXTRA_LDFLAGS=${LDFLAGS} | ||
| # export LDFLAGS= | ||
| # .. but instead it is better to strip off all '-Wl,-rpath,*' and '-L${PREFIX}' from LDFLAGS. |
There was a problem hiding this comment.
@mingwandroid, in light of the fact that we need rpath for libc++.dylib, is this a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #41