-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run all tests #142
run all tests #142
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There are 8 tests failing on ppc64le:
I don't think that ppc64le is used by many or if it is even support upstream. @conda-forge/netcdf4 team should we try to fix these or just skip? |
@ocefpaf, I'm afraid I don't know about whether the tests are expected to pass on @dopplershift, any insight into whether we would expect these tests to pass? |
@WardF Any insights on testing on ppc64le? |
Good to know! |
@dopplershift I would expect the libnetcdf tests to pass on ppc64le (and indeed they do, over at libnetcdf-feedstock). I would have to dig into the failures observed here to see if they are occurring at the C library level (in which case I can probably help) or somewhere in the Python code (in which case I am less equipped to help). But to answer the specific question, |
Thinking more about this, it is possible that the python testing is covering code that's not being tested in |
I went ahead and posted an issue: Unidata/netcdf4-python#1196 @jswhit, as the main developer I'm wondering if you would be willing to comment either there or here. |
so this is a new thing (testing on ppc64le) and not something that used to pass and now doesn't? |
@jswhit, yes, that's right. Some folks ran into trouble with the last release (see #141) and @ocefpaf decided to turn on a lot more testing, presumably to see if there were any obvious problems with the conda-forge build. In that process, everything worked great except |
some of the test failures are for cftime and appear to be related to be overflowing the range of 64 bit integers when casting from a float. I wonder if it could be a problem with the version of numpy being used. |
The |
That's just a wild guess - how hard would it be to try numpy 1.22 or 1.23? |
I'll look into doing that for testing purposes but part of what makes conda-forge work is that we have specific versions of packages like numpy that we use consistently across the ecosystem of packages. So if that's a requirement, we'd need to disable ppc64le support until we're ready to migrate to a newer numpy. |
@ocefpaf, if this works, maybe it would be possible to pin a higher version of numpy? According to the knowledge base, this is okay but what would be downstream consequences be? Also, could we pin just for ppc64le? I'm almost certainly jumping the gun since we don't know if it will work... |
No luck with numpy 1.22. let's try 1.23. |
@jswhit, I appreciate the recommendation but no luck there. Let us know if anything else comes to mind. |
BTW, we do run all the tests in the |
@ocefpaf, I think it's better at this point to just disable the tests for ppc64le as you suggested earlier. It seems better to have the tests for other architectures than not at all. If we or someone else has a chance to investigate the failures at a later time, that would be great! But we have to be realistic about our limited time right now. |
@xylar we don't need new artifacts to be built, so we can wait for a new release and just rebase here. I'm OK keeping this as a draft until then. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/netcdf4-feedstock/actions/runs/3487394746. |
Windows tests are passing, so that's the one that I was concerned about. the alternative linux architectures are clearly still having trouble. It's frustrating that so many folks are having trouble with DLLs in the windows version but I don't have any relevant expertise to help there or to debug with folks if it's just user error. |
Are folks reporting to you directly these failures? Are those with the conda-forge package? Sorry if I missed any important ping, I'm quite slow lately with my notifications. |
I don't work directly with anyone using Windows as far as I'm aware. |
@ocefpaf, great I'm glad you were able to help! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@xylar it seems that all the tests are passing now 🎉 Do you mind taking a look if I for it right? |
I'm a bit rusty on the details of this PR but everything looks good to me! |
It looks like the packages for build 0 are done so I'm going to merge this. |
This is something we should've done a long time ago.