Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

or-tools v9.4 #23

Merged
merged 18 commits into from
Mar 6, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Aug 11, 2022

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #21
Closes: #33

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2843381605, please use this URL for debugging.

@regro-cf-autotick-bot
Copy link
Contributor Author

Hi! This feedstock was not able to be rerendered after the version update changes. I
have pushed the version update changes anyways and am trying to rerender again with this
comment. Hopefully you all can fix this!

@conda-forge-admin rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GutHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/or-tools-feedstock/actions/runs/2843500539.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Something's going wrong with swig. It fails with 4.1, and with 4.0 we get:

from ortools.sat.python import swig_helper
ImportError: cannot import name 'swig_helper' from 'ortools.sat.python' ([...]/lib/python3.8/site-packages/ortools/sat/python/__init__.py)

on to 9.5...

@h-vetinari h-vetinari force-pushed the 9.4_hb6ab62 branch 3 times, most recently from a92fd67 to ad89712 Compare March 5, 2023 23:27
@h-vetinari
Copy link
Member

h-vetinari commented Mar 5, 2023

@conda-forge/or-tools, this is now finally green, at least for CPython. I don't know what's happening with PyPy (CC @mattip), but I propose to tackle this later, because this feedstock has been stuck for months already.

I've also taken the opportunity to rename ortools-cpp into libortools following conda-forge/conda-forge.github.io#1073. The old output is kept for compatibility, and I've added a run-export to both.

There are many things we should IMO be doing here (e.g. depending on libortools rather than rebuilding the C++ lib for the python bindings), but I think these should be done independently of reactivating this feedstock (I tried and failed with some trivial patching).

I've tried to do the same for 9.3, but ran into issues there due to the back and forth (upstream, e.g. this which landed for 9.4) between the re2-ABI between abseil and non-abseil. I'll rebase the PR for 9.5 once this PR lands.

PTAL :)

@BastianZim
Copy link
Member

Thanks @h-vetinari! You're much more knowledgeable about the whole build process so not going to add anything there. For the or-tools specific stuff, everything looks fine so please feel free to merge whenever you're ready. :)

Just fyi, upstream is really responsive and helpful if you ever need a clarification and they also happily upstream some of our temporary fixes, if you think it makes sense.

@h-vetinari h-vetinari merged commit ec2ca2e into conda-forge:main Mar 6, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 9.4_hb6ab62 branch March 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants