Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.4.0 #31

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Update to 3.4.0 #31

merged 3 commits into from
Aug 22, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Aug 19, 2017

No description provided.

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 21, 2017

Python 2.7 is failing on Windows with:

C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(206) : error C2039: 'back' : is not a member of 'std::basic_string<_Elem,_Traits,_Ax>'
        with
        [
            _Elem=char,
            _Traits=std::char_traits<char>,
            _Ax=std::allocator<char>
        ]
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(212) : error C2039: 'unique_ptr' : is not a member of 'std'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(212) : error C2143: syntax error : missing ';' before '<'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(212) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(212) : error C2143: syntax error : missing ';' before '{'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(212) : error C2447: '{' : missing function header (old-style formal list?)
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(221) : error C2039: 'unique_ptr' : is not a member of 'std'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(221) : error C2059: syntax error : ']'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(222) : error C2065: 'wbuf' : undeclared identifier
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(222) : error C2228: left of '.get' must have class/struct/union
        type is ''unknown-type''
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(223) : error C2065: 'wbuf' : undeclared identifier
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(223) : error C2228: left of '.get' must have class/struct/union
        type is ''unknown-type''
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(327) : error C2039: 'unique_ptr' : is not a member of 'std'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(327) : error C2059: syntax error : ']'
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(328) : error C2065: 'wmode' : undeclared identifier
C:\bld\protobuf_1503290160041\work\protobuf-3.4.0\src\google\protobuf\stubs\io_win32.cc(328) : error C2228: left of '.get' must have class/struct/union
        type is ''unknown-type''
NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.

I am incline to skip it instead of patching.

@hajapy
Copy link
Contributor

hajapy commented Aug 21, 2017

Seems like those are c++11 only features. Officially this was only supposed to begin being the case as of 3.5.0 (see https://github.com/google/protobuf/releases/tag/v3.4.0), so while this is probably technically an upstream bug, I doubt there will be much appetite for fixing it. I'd be ok with skipping the 2.7 windows build as it is an upstream issue.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 4a47177 into conda-forge:master Aug 22, 2017
@ocefpaf ocefpaf deleted the update_to-3.4.0 branch August 22, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants