Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright-node output to make package self-contained #184

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

moritzwilksch
Copy link
Member

@moritzwilksch moritzwilksch commented Oct 25, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The pyright feedstock currently packages a small Python wrapper around the pyright language server (written in TypeScript) that provides a CLI and LSP interface to the TypeScript package. However, the TypeScript code itself is not packaged in the feedstock. This causes the package to run an npm install in the background on its first invocation, requiring internet access.

Here, I'm adding the pyright-node output, also packaging the required javascript code to run pyright in a self-contained fashion, e.g. in an environment without internet.

closes #179
closes #178

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • The top level meta key schema_version is unexpected
  • There are too few lines. There should be one empty line at the end of the file.

For recipe/recipe.yaml:

  • No valid build backend found for Python recipe for package pyright using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • The top level meta keys are in an unexpected order. Expecting ['context', 'recipe', 'source', 'build', 'outputs', 'about', 'extra'].

For recipe/recipe.yaml:

  • It looks like the '???' output doesn't have any tests.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/build.bat.bak Outdated Show resolved Hide resolved
recipe/recipe.yaml Show resolved Hide resolved
recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/build_python.bat Outdated Show resolved Hide resolved
recipe/build_python.sh Outdated Show resolved Hide resolved
@moritzwilksch
Copy link
Member Author

this still looks a bit concerning, as if we still ran npm in the background 🤔

 │ │ │ Installing test environment
 │ │ │ ✔ Successfully updated the test environment
 │ │ │ Testing commands:
 │ │ │ + pyright --help
 │ │ │ added 1 package, and audited 2 packages in 1s  <<<<<<
 │ │ │ found 0 vulnerabilities
 │ │ │ Usage: pyright [options] files...

recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/recipe.yaml Show resolved Hide resolved
@moritzwilksch
Copy link
Member Author

runtime npm invocation fixed by setting correct cache dir: 9340325

@moritzwilksch
Copy link
Member Author

moritzwilksch commented Nov 12, 2024

linter doesn't like the rattler-build conditionals 🥲

recipe/recipe.yaml Outdated Show resolved Hide resolved
@moritzwilksch moritzwilksch marked this pull request as ready for review November 14, 2024 12:04
@thewchan
Copy link
Contributor

@conda-forge-admin please relint

@thewchan
Copy link
Contributor

@moritzwilksch do we know why linter is failing?

@moritzwilksch
Copy link
Member Author

moritzwilksch commented Nov 14, 2024

i think it doesn’t know the conditional syntax from the new recipe format? @pavelzw @ytausch

@pavelzw
Copy link
Member

pavelzw commented Nov 14, 2024

Yeah seems like it, cc @wolfv @nichmor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants