-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyright-node
output to make package self-contained
#184
base: main
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2024.10.25.11.54.39
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
For recipe/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
For recipe/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
…eAutomergeAndRerender
…nda-forge-pinning 2024.11.06.10.34.47
…nda-forge-pinning 2024.11.06.14.03.29
this still looks a bit concerning, as if we still ran npm in the background 🤔
|
runtime |
linter doesn't like the rattler-build conditionals 🥲 |
…nda-forge-pinning 2024.11.12.14.24.54
…nda-forge-pinning 2024.11.12.14.24.54
@conda-forge-admin please relint |
@moritzwilksch do we know why linter is failing? |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)The pyright feedstock currently packages a small Python wrapper around the pyright language server (written in TypeScript) that provides a CLI and LSP interface to the TypeScript package. However, the TypeScript code itself is not packaged in the feedstock. This causes the package to run an npm install in the background on its first invocation, requiring internet access.
Here, I'm adding the
pyright-node
output, also packaging the required javascript code to runpyright
in a self-contained fashion, e.g. in an environment without internet.closes #179
closes #178