Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ffi issue #525

Merged
merged 8 commits into from
Nov 20, 2021
Merged

Fix ffi issue #525

merged 8 commits into from
Nov 20, 2021

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 20, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #522
Closes #523
Closes #524

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf mentioned this pull request Nov 20, 2021
Closed
3 tasks
@isuruf
Copy link
Member Author

isuruf commented Nov 20, 2021

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label Nov 20, 2021
@github-actions github-actions bot merged commit 3295439 into conda-forge:master Nov 20, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari
Copy link
Member

One of the travis builds for this failed after merging - could someone restart it?

@h-vetinari
Copy link
Member

Thanks for restarting!

Also: awesome work by lots of people in terms of connecting many different dots. 🥳

@jakirkham jakirkham mentioned this pull request Nov 20, 2021
Merged
@mbargull
Copy link
Member

Also: awesome work by lots of people in terms of connecting many different dots. partying_face

Very much agreed! Thanks to everyone involved for digging up everything to get to the button and fixing this!

@mbargull mbargull mentioned this pull request Nov 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@mbargull mbargull Awaiting requested review from mbargull

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@msarahan msarahan Awaiting requested review from msarahan

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

@pelson pelson Awaiting requested review from pelson

@scopatz scopatz Awaiting requested review from scopatz

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.10.0 crashes on MacOS x86_64
5 participants
@isuruf @conda-forge-linter @h-vetinari @mbargull @jakirkham