Force siphash24 hash algorithm when cross-compiling #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling, the hash function is forced to be FNV because the configure script defines `HAVE_ALIGNED_REQUIRED` which is then used by pyhash.h to change the default to FNV (see conda-forge#718) This commit fixes the issue by specifying siphash24 to the configure script when cross-compiling.
|
@conda-forge-admin, please rerender |
1 task
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.09.24.05.02.56
|
Can you add a test? |
This was referenced Oct 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling, the hash function is forced to be FNV because the configure script defines
HAVE_ALIGNED_REQUIREDwhich is then used by pyhash.h to change the default to FNV (see #718).This PR fixes the issue by specifying siphash24 to the configure script when cross-compiling. With this PR, I now get:
instead of
I'm not that familiar with the setup of this feedstock so I don't know if this is an appropriate solution or more of a sketch of a solution - any feedback / guidance is appreciated!
Checklist
Reset the build number to0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)