Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set MACOSX_*** overrides in conda_build_config.yaml for x86_64 #31

Closed
wants to merge 1 commit into from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 15, 2024

@xhochy originally raised the point in conda-forge/staged-recipes#25648 (comment).

Setting this only for x86_64 is necessary as on osx-arm64 the default value of MACOSX_DEPLOYMENT_TARGET is already 11, see https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/070f9140d5ab27ef0d109c6b65c80cf0756bbe26/recipe/conda_build_config.yaml#L111, and there is no reason to override it with a lower value.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • {'store_build_artifacts': True, 'artifact_retention_days': 14} is not valid under any of the given schemas

Failed validating 'anyOf' in schema['properties']['azure']:
{'anyOf': [{'$ref': '#/$defs/AzureConfig'}, {'type': 'null'}],
'description': 'Azure Pipelines CI settings. This is usually '
'read-only and should not\n'
'normally be manually modified. Tools like '
'conda-smithy may modify this, as needed.\n'
'For example:\n'
'\n'
'yaml\n' 'azure:\n' ' # flag for forcing the building all supported ' 'providers\n' ' force: False\n' ' # toggle for storing the conda build_artifacts ' 'directory (including the\n' ' # built packages) as an Azure pipeline artifact ' 'that can be downloaded\n' ' store_build_artifacts: False\n' ' # toggle for freeing up some extra space on the ' 'default Azure Pipelines\n' ' # linux image before running the Docker container ' 'for building\n' ' free_disk_space: False\n' ' # limit the amount of CI jobs running ' 'concurrently at a given time\n' ' # each OS will get its proportional share of the ' 'configured value\n' ' max_parallel: 25\n' '\n'
'\n'
'Below is an example configuration for setting up a '
'self-hosted Azure agent for Linux:\n'
'\n'
'yaml\n' 'azure:\n' ' settings_linux:\n' ' pool:\n' ' name: your_local_pool_name\n' ' demands:\n' ' - some_key -equals some_value\n' ' workspace:\n' ' clean: all\n' ' strategy:\n' ' maxParallel: 1\n' '\n'
'\n'
'Below is an example configuration for adding a '
'swapfile on an Azure agent for Linux:\n'
'\n'
'yaml\n' 'azure:\n' ' settings_linux:\n' ' swapfile_size: 10GiB\n' ''}

On instance['azure']:
{'store_build_artifacts': True, 'artifact_retention_days': 14}

@traversaro
Copy link
Contributor Author

I did not re-render or bumped the build number as I guess we can just merge this change so it is available at the next update. Let me know if you want me to fix the conda-linter regression in this PR, or if you prefer that to be handled in a different PR, thanks!

@ruben-arts
Copy link
Contributor

Thanks @traversaro

@traversaro traversaro mentioned this pull request Mar 20, 2024
5 tasks
@traversaro
Copy link
Contributor Author

Integrated in #32 .

@traversaro traversaro closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants