Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RSASecurID support #15016

Closed
wants to merge 3 commits into from
Closed

Conversation

milljm
Copy link
Member

@milljm milljm commented May 24, 2021

Initial commit to add rsasecure_login to conda-forge.
Note: This package requires a milestone conda/conda#10667

This is a work in progress. Aside from the obvious milestone requirement, I am not
sure I like the command name rsasecure_login.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Initial commit to add rsasecure_login to conda-forge.
Note: This package requires a milestone conda/conda#10667

This is a work in progress. Aside from the obvious milestone requirement, I am not
sure I like the command name `rsasecure_login`.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rsasecure_login) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rsasecure_login:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@milljm
Copy link
Member Author

milljm commented May 24, 2021

I hereby state I will be the maintainer for rsasecure_login.

Satisfy pylint.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rsasecure_login) and found it was in an excellent condition.

@milljm milljm changed the title Initial commit for RSASecureID support Initial commit for RSASecurID support May 24, 2021
@milljm milljm changed the title Initial commit for RSASecurID support add RSASecurID support May 24, 2021
Add LICENSE.txt. Copied the one already supplied by staged-recipes, as BSD or MIT is fine.
Fix the summary description. The product in question which this package supplies support for, is RSASecurID.
@milljm
Copy link
Member Author

milljm commented May 24, 2021

Closing because the accompanying Conda change will not be allowed to happen in it's current state. I do see this as a good thing, as it broadens my scope to include not just one specific MFA branding.

@milljm milljm closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants