Add arpack #1561

jschueller · 2016-09-13T14:33:02Z

No description provided.

conda-forge-linter · 2016-09-13T14:33:15Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arpack) and found it was in an excellent condition.

conda-forge-linter · 2016-09-13T15:22:35Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arpack, recipes/arpackpp) and found it was in an excellent condition.

jakirkham · 2016-09-19T01:37:35Z

recipes/arpack/meta.yaml

+
+about:
+  home: https://github.com/opencollab/arpack-ng
+  license: BSD


What version of BSD (e.g. BSD 3-Clause)?

Done below.

jakirkham · 2016-09-19T01:38:11Z

recipes/arpackpp/meta.yaml

+
+about:
+  home: http://www.ime.unicamp.br/~chico/arpack++/
+  license: BSD


What version of BSD (e.g. BSD 3-Clause)?

3-clause, ok

jakirkham · 2016-09-19T01:39:14Z

recipes/arpackpp/meta.yaml

+
+requirements:
+  run:
+    - arpack


Just to confirm, this is header only?

jakirkham · 2016-09-19T01:39:29Z

recipes/arpack/meta.yaml

+  skip: true  # [win]
+
+requirements:
+  build:


Please add toolchain.

This doesn't appear to be addressed.

Oh sorry I thought it was.

No worries. Thanks for addressing.

jakirkham · 2016-09-19T01:39:40Z

recipes/arpack/meta.yaml

+    - openblas 0.2.18*
+
+  run:
+    - libgcc


Please change to libgfortran.

This doesn't appear to be addressed.

jakirkham · 2016-09-19T01:40:38Z

recipes/arpack/build.sh

+
+make -j${CPU_COUNT}
+cp lib/libarpack${SO_EXT} ${PREFIX}/lib
+DYLD_FALLBACK_LIBRARY_PATH=${PREFIX}/lib make check -j${CPU_COUNT}


No make install?

was add, in master only

jakirkham · 2016-09-19T01:41:28Z

recipes/arpackpp/meta.yaml

+
+source:
+  fn: arpackpp-{{ version }}.tar.gz
+  url: http://www.ime.unicamp.br/~chico/arpack++/arpack++.tar.gz


Do they have versioned releases? This seems a bit fragile.

no they have not

I'm also seeing this webpage for it, which points at this repo.

yeah, it should be this one, with versioned releases

jakirkham · 2016-09-19T01:43:04Z

recipes/arpack/meta.yaml

+
+source:
+  fn: arpack-{{ version }}.tar.gz
+  url: https://github.com/opencollab/arpack-ng/archive/{{ version }}.tar.gz


Are we sure this is the official version? If so, what convinces us?

It's the one packaged in debian.

AFAICT you are correct to use this. Arch Linux and Gentoo both use this too. Not sure about other Linux distros though.

jakirkham · 2016-09-19T01:43:43Z

recipes/arpack/meta.yaml

+    - gcc
+    - cmake
+    - blas 1.1 {{ variant }}
+    - openblas 0.2.18*


Please change to 0.2.18|0.2.18.*.

This doesn't appear to be addressed.

jakirkham · 2016-09-19T01:43:47Z

recipes/arpack/meta.yaml

+  run:
+    - libgcc
+    - blas 1.1 {{ variant }}
+    - openblas 0.2.18*


Please change to 0.2.18|0.2.18.*.

This doesn't appear to be addressed.

conda-forge-linter · 2016-09-19T08:12:53Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2016-09-19T08:15:35Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arpack, recipes/arpackpp) and found it was in an excellent condition.

conda-forge-linter · 2016-09-19T08:22:19Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2016-09-19T08:23:44Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arpack, recipes/arpackpp) and found it was in an excellent condition.

jschueller · 2016-09-26T08:14:20Z

is it good to go ?

jakirkham · 2016-09-26T11:17:35Z

It seems there are a bunch of comments that are still not addressed. Could you please address them? Then will take another look.

jschueller · 2016-09-26T11:46:41Z

@jakirkham they're all adressed, except for the static libs remark which I do not agree

jakirkham · 2016-09-26T12:04:38Z

recipes/arpackpp/meta.yaml

+
+about:
+  home: http://www.ime.unicamp.br/~chico/arpack++/
+  license: BSD 3-Clause


Please add the license file.

jakirkham · 2016-09-26T13:07:49Z

recipes/arpack/meta.yaml

+extra:
+  recipe-maintainers:
+    - jschueller
+


nit: Please make one terminal newline just like arpackpp/meta.yaml.

jakirkham · 2016-09-26T13:08:51Z

recipes/arpack/meta.yaml

+  commands:
+    - test -f ${PREFIX}/lib/libarpack.a  # [unix]
+    - test -f ${PREFIX}/lib/libarpack.so  # [linux]
+    - test -f ${PREFIX}/lib/libarpack.dylib  # [osx]


jakirkham · 2016-09-26T13:10:09Z

LGTM. Thanks @jschueller. Will merge once it passes.

jakirkham · 2016-09-26T13:10:21Z

Sorry wrong button. 😳

tkelman mentioned this pull request Sep 18, 2016

Add Julia #1618

Closed

jakirkham reviewed Sep 19, 2016

View reviewed changes

jakirkham reviewed Sep 26, 2016

View reviewed changes

jschueller added 2 commits September 26, 2016 15:09

Add arpack

778230f

Add arpackpp

6847e8b

jakirkham approved these changes Sep 26, 2016

View reviewed changes

jakirkham closed this Sep 26, 2016

jakirkham reopened this Sep 26, 2016

jakirkham merged commit e77b02e into conda-forge:master Sep 26, 2016

jschueller deleted the arpack branch September 26, 2016 13:28

Add arpack #1561

Add arpack #1561

Conversation

jschueller commented Sep 13, 2016

conda-forge-linter commented Sep 13, 2016

conda-forge-linter commented Sep 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham Sep 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jschueller Sep 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jschueller Sep 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Sep 19, 2016

conda-forge-linter commented Sep 19, 2016

conda-forge-linter commented Sep 19, 2016

conda-forge-linter commented Sep 19, 2016

jschueller commented Sep 26, 2016

jakirkham commented Sep 26, 2016

jschueller commented Sep 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Sep 26, 2016

jakirkham commented Sep 26, 2016

jakirkham Sep 19, 2016 •

edited

Loading

jschueller Sep 19, 2016 •

edited

Loading

jschueller Sep 26, 2016 •

edited

Loading