-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pynsist as a package #20138
Added pynsist as a package #20138
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes Tests pass except for win build; it's noarch. But it seems in the win build the wheel/package was successfully build, but not successfully installed in the win environment. Not sure why? Any pointers? |
This package is not actually noarch! It tries to ship pre-compiled DLLs (which is not allowed). I'm not even sure that this package is appropriate for unix because it "Builds Windows installers for Python applications". |
It should be Windows noarch only, we can do that now, see conda-forge/conda-forge.github.io#1839. Also, while I don't like the idea of shipping DLLs, this does seem to be the recommended way in this particular case. See the discussion in: takluyver/pynsist#84 |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).