Add PySurfer #2201

christianbrodbeck · 2017-01-12T18:55:43Z

No description provided.

conda-forge-linter · 2017-01-12T18:55:52Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysurfer) and found it was in an excellent condition.

conda-forge-linter · 2017-01-13T11:02:55Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pysurfer) and found some lint.

Here's what I've got...

For recipes/pysurfer:

The recipe must have some tests.

conda-forge-linter · 2017-01-13T11:08:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysurfer) and found it was in an excellent condition.

christianbrodbeck · 2017-01-19T16:43:20Z

I've excluded Linux because it looks like vtk is broken (see https://circleci.com/gh/conda-forge/staged-recipes/12483?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link where import vtk failed)

jakirkham · 2017-01-22T22:12:55Z

recipes/pysurfer/meta.yaml

+# To update, change version number and sha256 -- you can get it for a file with:
+#  `openssl sha256 <file name>`.
+# You may need the openssl package, available on conda-forge
+#  `conda install openssl -c conda-forge``


Please drop this comment.

jakirkham · 2017-01-22T22:13:26Z

recipes/pysurfer/meta.yaml

+
+build:
+  number: 0
+  skip: True  # [py>=30 or linux]


py>=30 is just py3k for simplicity.

jakirkham · 2017-01-22T22:13:58Z

recipes/pysurfer/meta.yaml

+    - mayavi
+    - nibabel
+    - numpy
+    - scipy


Are all of these need at build time? Normally just python and maybe setuptools are needed.

The reason for these dependencies is that PySurfer checks dependencies in setup.py, raising an error if they are not installed (rather than specifying them as deopendencies, because it is assumed that they are easier to install from a source other than PYPI) see https://github.com/nipy/PySurfer/blob/master/setup.py#L38

jakirkham · 2017-01-22T22:14:22Z

recipes/pysurfer/meta.yaml

+about:
+  home: http://pysurfer.github.com
+  license: BSD-3-clause
+  license_family: BSD


Is there a license file in the source that we can include here?

The license file is in the repository, but it's not included in the source distribution. It could probably be added in future versions.

dfroger · 2017-01-27T12:48:06Z

For linux broken build, I think py-surfer recipe need to add libXt-devel and mesa-libGLU-devel to its yum_requirements.txt, like the mayavi one

christianbrodbeck · 2017-01-27T13:19:52Z

Thanks @dfroger, this fixed circleci! So it looks like vtkRenderingOpenGLPython is dynamically generated only when certain requirements are present?

I did not see yum_requirements.txt mentioned in the documentation, maybe a mention of yum_requirements.txt and suggestion to check the yum_requirements.txt of dependencies at https://conda-forge.github.io/#add_recipe or in the sample script would be helpful?

christianbrodbeck · 2017-01-29T18:23:25Z

Getting a strange appveyor error in windows (which worked before): https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.10899/job/6o4arksrpa9t2yoj#L306 Is that something I can fix?

[edit: seems to be good now]

christianbrodbeck · 2017-02-01T22:02:19Z

@conda-forge/core This is ready for review.

patricksnape · 2017-02-01T22:07:04Z

recipes/pysurfer/meta.yaml

+
+build:
+  number: 0
+  skip: True  # [py3k]


What is Python 2 only? All the dependencies are Python 3 compatible?

Enabled py3k, thanks @patricksnape

christianbrodbeck · 2017-02-01T22:43:50Z

@patricksnape now I get (https://circleci.com/gh/conda-forge/staged-recipes/13015?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

The following specifications were found to be in conflict:
  - numpy 1.9*
  - python 3.5*

patricksnape · 2017-02-02T21:56:26Z

That seems like something needs to be rebuilt with the latest numpy

christianbrodbeck · 2017-02-02T22:17:13Z

I don't know how to go about this @patricksnape, should I roll back to exclude py3k support so this can get started, and py3k support can be added later when the dependencies work?

patricksnape · 2017-02-05T16:23:51Z

Sure that sounds fine, just make an issue on the new repo when it's up for Python 3 support

christianbrodbeck · 2017-02-05T16:59:11Z

Ok, I reverted back to skipping py3k, so this is ready again.

WIP: PySurfer recipe

4b22706

christianbrodbeck added 5 commits January 13, 2017 01:58

FIX name

8e39aa4

FIX: license file is not bundled in sdist

0be7eaa

test

4cac35d

test

9a599e9

remove test

451b26d

test --help

a8d2b08

christianbrodbeck added 2 commits January 13, 2017 12:33

test xvfb

8899216

add xvfb?

0d69b3f

christianbrodbeck force-pushed the surfer branch 3 times, most recently from 238c09a to 0d69b3f Compare January 17, 2017 18:48

Disable linux build (installs VTK 7)

499bc7a

christianbrodbeck force-pushed the surfer branch from 85fc76b to 499bc7a Compare January 18, 2017 16:08

STY remove comments

0826737

jakirkham reviewed Jan 22, 2017

View reviewed changes

recipes/pysurfer/meta.yaml Outdated

build:

number: 0

skip: True # [py>=30 or linux]

Copy link

Member

jakirkham Jan 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py>=30 is just py3k for simplicity.

jakirkham reviewed Jan 22, 2017

View reviewed changes

christianbrodbeck added 2 commits January 22, 2017 21:26

STY

a28dbe9

test: enable linux

9773f4c

christianbrodbeck mentioned this pull request Jan 25, 2017

vtk broken? conda-forge/vtk-feedstock#21

Closed

update yum_requirements

efa0ce5

build req

c37237c

christianbrodbeck changed the title ~~WIP: PySurfer recipe~~ Add PySurfer Jan 31, 2017

christianbrodbeck mentioned this pull request Jan 31, 2017

Conda-forge nipy/PySurfer#174

Closed

add maintainer [ci skip]

77be106

patricksnape reviewed Feb 1, 2017

View reviewed changes

christianbrodbeck force-pushed the surfer branch from 7ab3bcb to 77be106 Compare February 5, 2017 16:57

patricksnape merged commit 112339c into conda-forge:master Feb 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PySurfer #2201

Add PySurfer #2201

christianbrodbeck commented Jan 12, 2017

conda-forge-linter commented Jan 12, 2017

conda-forge-linter commented Jan 13, 2017

conda-forge-linter commented Jan 13, 2017

christianbrodbeck commented Jan 19, 2017

jakirkham Jan 22, 2017

jakirkham Jan 22, 2017

jakirkham Jan 22, 2017

christianbrodbeck Jan 22, 2017

jakirkham Jan 22, 2017

christianbrodbeck Jan 22, 2017

dfroger commented Jan 27, 2017

christianbrodbeck commented Jan 27, 2017

christianbrodbeck commented Jan 29, 2017 •

edited

Loading

christianbrodbeck commented Feb 1, 2017

patricksnape Feb 1, 2017

christianbrodbeck Feb 1, 2017

christianbrodbeck commented Feb 1, 2017

patricksnape commented Feb 2, 2017

christianbrodbeck commented Feb 2, 2017

patricksnape commented Feb 5, 2017

christianbrodbeck commented Feb 5, 2017

Add PySurfer #2201

Add PySurfer #2201

Conversation

christianbrodbeck commented Jan 12, 2017

conda-forge-linter commented Jan 12, 2017

conda-forge-linter commented Jan 13, 2017

conda-forge-linter commented Jan 13, 2017

christianbrodbeck commented Jan 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfroger commented Jan 27, 2017

christianbrodbeck commented Jan 27, 2017

christianbrodbeck commented Jan 29, 2017 • edited Loading

christianbrodbeck commented Feb 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianbrodbeck commented Feb 1, 2017

patricksnape commented Feb 2, 2017

christianbrodbeck commented Feb 2, 2017

patricksnape commented Feb 5, 2017

christianbrodbeck commented Feb 5, 2017

christianbrodbeck commented Jan 29, 2017 •

edited

Loading