Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cocotb #22323

Merged
merged 4 commits into from
Apr 18, 2023
Merged

add cocotb #22323

merged 4 commits into from
Apr 18, 2023

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Mar 18, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

—-

Closes #21056

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found some lint.

Here's what I've got...

For recipes/cocotb:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found it was in an excellent condition.

@timkpaine timkpaine marked this pull request as ready for review March 18, 2023 19:31
@timkpaine
Copy link
Member Author

need to pull the 3 missing licenses of vendored files, 2 of which come from IEEE language reference manuals and 1 is apache 2.0 (but i need to get the license text).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found some lint.

Here's what I've got...

For recipes/cocotb:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

timkpaine commented Mar 18, 2023

@conda-forge/help-python-c need some help diagnosing behavior, it looks like the first build works fine but then subsequent versions end up with errors like:

ERROR (cocotb,lib/python3.9/site-packages/cocotb/libs/<all the libs>): lib/python3.8/site-packages/cocotb/libs/libgpi.so not found in any packages

e.g. during the build for 3.9, its looking for libs from 3.8.

on OS X its similar, except it builds 3.10 before 3.9

ERROR (cocotb,lib/python3.9/site-packages/cocotb/libs/libpygpilog.so): lib/python3.10/site-packages/cocotb/libs/libgpilog.so not found in any packages

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found some lint.

Here's what I've got...

For recipes/cocotb:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cocotb) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

Can't seem to build 3 versions at the same time so will limit to one until the feedstock is rendered.

fix lint

find-libpython required at runtime

remove skip copy pasta

skip windows, run exports, add runtime constraints for simulators, add more license

add more licenses

fix lint

remove that flag

try cleaning every time before build

more experiements

more experiments

more experiments

.

.

.

.

start on some patches

more debug

Try with a build script

trying random stuff now

more debugging

.

.

.

.

Update meta.yaml

.

.:
@timsnyder
Copy link
Contributor

I started trying to look at this because it's really weird. It has been a really long time since I looked at the overlinking checks code but I'm starting to think this is definitely an issue with how conda-forge's build_all.py is building multiple versions and state in the overlinking checks is bleeding from one build to the next. I don't know if I'll find time to look at this any more but there may be something really broken here in the infrastructure. I think restricting it to a single python until you're in the feedstock and the builds are isolated is a good idea.

@timkpaine
Copy link
Member Author

@conda-forge/staged-recipes @conda-forge/core fyi

@isuruf
Copy link
Member

isuruf commented Mar 20, 2023

https://github.com/conda/conda-build/blob/c5146a02c1b86033a7989718b1511969838db5dd/conda_build/os_utils/liefldd.py#L936-L977 caches by file contents, but does not cache the file name itself. Please open an issue in conda-build.

@timkpaine
Copy link
Member Author

@isuruf / @conda-forge/staged-recipes i opened conda/conda-build#4821 but seems it will be a wait, since this issue only effects in staged-recipes can we merge this and get the feedstock rolled out?

@carterbox carterbox closed this Apr 18, 2023
@carterbox carterbox reopened this Apr 18, 2023
recipes/cocotb/meta.yaml Outdated Show resolved Hide resolved
recipes/cocotb/meta.yaml Show resolved Hide resolved
recipes/cocotb/meta.yaml Show resolved Hide resolved
recipes/cocotb/meta.yaml Show resolved Hide resolved
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
timkpaine and others added 2 commits April 18, 2023 14:28
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@carterbox
Copy link
Member

Merge when builds pass.

@carterbox carterbox merged commit ca187c4 into conda-forge:main Apr 18, 2023
@timkpaine timkpaine deleted the tkp/cocotb branch April 18, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants