Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for the stream-zip Python package from PyPI #24588

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

michalc
Copy link
Contributor

@michalc michalc commented Nov 26, 2023

This adds the stream-zip Python package from PyPI as a conda-forge recipe.

This is the sibling package of stream-unzip, already added to conda-forge in #20058. Also, stream-zip not being on conda-forge is blocking the update of the eodag package that has stream-zip as a dependency. See the following for details:

conda-forge/eodag-feedstock#22
CS-SI/eodag#933
uktrade/stream-zip#90

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/stream-zip) and found some lint.

Here's what I've got...

For recipes/stream-zip:

  • The home item is expected in the about section.

@michalc
Copy link
Contributor Author

michalc commented Nov 26, 2023

I confirm I am willing to be listed in the maintainers section

This adds the stream-zip Python package from PyPI as a conda-forge recipe.

This is the sibling package of stream-unzip, already added to conda-forge in
conda-forge#20058. Also, stream-zip not
being on conda-forge is blocking the update of the eodag package that has
stream-zip as a dependency. See the following for details:

conda-forge/eodag-feedstock#22
CS-SI/eodag#933
uktrade/stream-zip#90
@michalc michalc force-pushed the add-stream-zip-python-pypi branch from 9765407 to 9163f77 Compare November 26, 2023 08:00
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stream-zip) and found it was in an excellent condition.

@michalc
Copy link
Contributor Author

michalc commented Nov 26, 2023

@conda-forge-admin, please ping conda-forge/help-python

I think this PR is ready for review, and as a first time contributor, am unable to ping the conda-forge/help-python directly

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

michalc added a commit to uktrade/stream-unzip that referenced this pull request Nov 26, 2023
This adds a conda-forge badge showing the current version of stream-unzip
published to conda forge, with a link to the conda-forge page at
https://anaconda.org/conda-forge/stream-unzip

While the package was added without knowledge of anyone involved with
stream-unzip as far as I know, it seems a reasonable option for conda-based
people to install stream-unzip, and allows other conda packages to depend on it
as well from what I can tell.

I have also started the process of publishing stream-zip to conda-forge as well
conda-forge/staged-recipes#24588
@ocefpaf ocefpaf merged commit dc03ad7 into conda-forge:main Nov 27, 2023
5 checks passed
@michalc michalc deleted the add-stream-zip-python-pypi branch November 27, 2023 11:15
michalc added a commit to uktrade/stream-zip that referenced this pull request Nov 29, 2023
This adds a badge showing the current package version on conda-forge, with a
link to it at https://anaconda.org/conda-forge/stream-zip

stream-zip has been recently added to conda-forge via
conda-forge/staged-recipes#24588, with its feedstock
repo at https://github.com/conda-forge/stream-zip-feedstock, so this is done
for slightly easier discoverability that it's on conda forge and an option for
users.

This is also done for consistency with the sibling project, stream-unzip, which
has a badge at the top of its README at https://github.com/uktrade/stream-unzip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants