Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize environment provision times with pixi #27754

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Oct 2, 2024

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

Copy link

github-actions bot commented Oct 2, 2024

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • .ci_support/requirements.yaml:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .azure-pipelines/azure-pipelines-win.yml:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .ci_support/requirements.txt:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .gitattributes:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .scripts/run_osx_build.sh:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .gitignore:

    • lints:
      • Do not edit files outside of the recipes/ directory.
  • .scripts/run_win_build.bat:

    • lints:
      • Do not edit files outside of the recipes/ directory.

Copy link

github-actions bot commented Oct 2, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@jaimergp
Copy link
Member Author

jaimergp commented Oct 2, 2024

With pixi, importing the dependencies into a new toml and solving from scratch.

macOS needs 24s to deploy base:

2024-10-02T22:14:28.5022520Z Downloading pixi 0.30.0
2024-10-02T22:14:29.6253360Z + echo 'Creating environment'
2024-10-02T22:14:52.5630520Z ##[group]Configuring conda

On Windows, 26s:

2024-10-02T22:14:34.0143231Z Downloading pixi 0.30.0
2024-10-02T22:14:36.9925817Z Creating environment
2024-10-02T22:15:50.0624206Z ##[group]Configuring conda

@ruben-arts
Copy link
Contributor

What are the original numbers before this PR?

@jaimergp
Copy link
Member Author

jaimergp commented Oct 3, 2024

See conda-forge/conda-forge.github.io#2323 (comment), @ruben-arts!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

@@ -0,0 +1,13 @@
name: staged-recipes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the deps here and in the .toml is not ideal. Any way around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants