Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with both GCC 7 & 9 #20

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Build with both GCC 7 & 9 #20

merged 3 commits into from
Jan 4, 2021

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jan 4, 2021 •
edited
Loading

As we use this with some older CUDA versions where GCC 7 is required, build this with GCC 7 as well as GCC 9.

cc @hcho3 @JohnZed @kkraus14

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jakirkham
Build with both GCC 7 & 9
a8af587
@jakirkham
MNT: Re-rendered with conda-build 3.20.5, conda-smithy 3.8.6, and con…
d914505 
…da-forge-pinning 2021.01.03.16.11.28

Now that GCC 7 & 9 are both used, re-render the feedstock to produce the
CI jobs corresponding to those builds.
@jakirkham
Bump build number to 1
aa9011c 
Not strictly needed here, but it should make it clearer that both GCC 7
& 9 were being used to build these packages.
@jakirkham jakirkham requested a review from hcho3 as a code owner January 4, 2021 20:30
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render.

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@jakirkham jakirkham mentioned this pull request Jan 4, 2021
Merged
@hcho3
Copy link
Contributor

hcho3 commented Jan 4, 2021

For some reason, the PPC64LE builds on Travis CI are very flaky, crashing without any stack trace.

@jakirkham
Copy link
Member Author

Yeah I've been seeing that as well. Have restarted ones that appeared to be wonky, which cleared some of the errors. That said, maybe we can just merge and restart the jobs on master instead since we know these are just flaky. WDYT? :)

@hcho3 hcho3 merged commit eda5825 into conda-forge:master Jan 4, 2021
@hcho3
Copy link
Contributor

hcho3 commented Jan 4, 2021

Merged. Thanks!

@jakirkham jakirkham deleted the bld_gcc_7_9 branch January 4, 2021 22:16
@jakirkham
Copy link
Member Author

Took a bit of restarting, but it looks like Travis CI now passes on master.

@isuruf
Copy link
Member

isuruf commented Jan 13, 2021

Please revert this PR. There's no reason to add GCC 7 & 9 builds for C/C++ packages. One is enough. This is against what we discussed in core meetings.

cc @conda-forge/core

@jakirkham
Copy link
Member Author

Please revert this PR. There's no reason to add GCC 7 & 9 builds for C/C++ packages. One is enough. This is against what we discussed in core meetings.

cc @conda-forge/core

I'm happy to discuss with you why this was needed at the core meeting tomorrow.

cc @kkraus14 (for vis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @conda-forge-linter @hcho3 @isuruf