Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noarch: python (with __win requirement) #24

Merged
merged 8 commits into from
Oct 26, 2022

Conversation

conda-forge-linter
Copy link

@conda-forge-linter conda-forge-linter commented Oct 25, 2022

Follows the process described in PR ( conda-forge/conda-forge.github.io#1839 )


Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #23.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #23

@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits October 25, 2022 20:19
@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham changed the title MNT: rerender Use noarch: python (with __win requirement) Oct 25, 2022
@jakirkham
Copy link
Member

@ocefpaf, if you have a moment, could you please review this? Would like a second set of eyes 🙂

Hoping this saves us thinking about future migrations here 😉

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@ocefpaf ocefpaf merged commit 3fedcde into conda-forge:main Oct 26, 2022
@jakirkham
Copy link
Member

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please re-render
5 participants