Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align string_prefix across dependencies #188

Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jul 31, 2024

As observed in @trivialfis 's comment ( #167 (comment) ), the packages here do not sufficiently constrain the CUDA version. To fix this, make sure that the string_prefix matches across dependencies (in addition to properly constraining the version number)


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Rebuild packages with `string_prefix` pinning alignment across packages.
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request Jul 31, 2024
3 tasks
@@ -113,12 +113,14 @@ outputs:
host:
- {{ pin_subpackage('_py-xgboost-mutex', exact=True) }}
- {{ pin_subpackage('libxgboost', max_pin='x.x.x') }}
- libxgboost =*={{ string_prefix }}_h*_{{ PKG_BUILDNUM }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the string_prefix and the build/number, which means we get the same generation of packages together

@jakirkham
Copy link
Member Author

@conda-forge-admin , please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10186004207.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jul 31, 2024
@github-actions github-actions bot merged commit 3fe446a into conda-forge:main Jul 31, 2024
15 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants