Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable builds on osx_arm64 #69

Merged
merged 7 commits into from
Apr 20, 2022
Merged

Conversation

Xarthisius
Copy link
Contributor

@Xarthisius Xarthisius commented Apr 19, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've bumped some of the linux builds too. Is that intentional?

@Xarthisius
Copy link
Contributor Author

Xarthisius commented Apr 19, 2022

It looks like you've bumped some of the linux builds too. Is that intentional?

That happened after I rerendered the recipe. I won't pretend to know what conda smithy is doing.

@munkm
Copy link
Member

munkm commented Apr 19, 2022

It looks like you've bumped some of the linux builds too. Is that intentional?

That happened after I rerendered the recipe. I won't pretend to know what conda smithy is doing.

🧙 🪄 ⭐

@Xarthisius
Copy link
Contributor Author

So the good news is that osx/arm64 builds just fine. Bad news is that latest template for linux/aarch and linux/pcc64 seems broken... fun...

@Xarthisius Xarthisius merged commit 104b485 into conda-forge:main Apr 20, 2022
@Xarthisius Xarthisius deleted the enable_osx_arm branch April 20, 2022 19:27
@jakirkham jakirkham mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants