Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yt v4.1.0 #74

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Oct 6, 2022

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
ctng-compilers 12.1.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pytest
  • bottle
  • arm_pyart
  • pyyaml
  • nose

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3200802046, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@neutrinoceros
Copy link
Contributor

@Xarthisius can you briefly explain why you renounced building for Python 3.7 ? Also, I assume it's not possible yet to compile for 3.11 ? (Just want to make sure I mention these exceptions in the release notes)

@Xarthisius
Copy link
Contributor

Xarthisius commented Oct 7, 2022

@Xarthisius can you briefly explain why you renounced building for Python 3.7 ? Also, I assume it's not possible yet to compile for 3.11 ? (Just want to make sure I mention these exceptions in the release notes)

It errored out with missing dependency on importlib-metadata (at least some functionality that's a part of stdlib since 3.8). I assumed you dropped the support. Wasn't that intentional?

AFAIR it was importing something from mpl, so it wasn't stricte our dependency but theirs. Unfortunately the most recent mpl already dropped py3.7 too:
https://github.com/conda-forge/matplotlib-feedstock/blob/main/recipe/meta.yaml#L22

@neutrinoceros
Copy link
Contributor

I assumed you dropped the support. Wasn't that intentional?

We have not dropped support for Python 3.7 yet. It is scheduled for yt 4.2 though yt-project/yt#4101
In fact yt 4.1 only requires importlib-metadata on Python 3.7, but I understand that managing conditional dependencies is harder on conda-forge.

To be clear, I am not opposing we drop 3.7 "early" on conda-forge (as you mentioned, matplotlib, as well as numpy, already dropped it a while back), and I'm confident that { 3.8, 3.9, 3.10 } should cover a vast majority of our users, so it's fine.

@Xarthisius
Copy link
Contributor

Xarthisius commented Oct 7, 2022

In fact yt 4.1 only requires importlib-metadata on Python 3.7

If it's requires it why it's not reflected in dependencies? I can add it to the recipe, but shouldn't it be in setup.cfg?

@neutrinoceros
Copy link
Contributor

it is included in setup.cfg:
https://github.com/yt-project/yt/blob/761f8059fd1975221c8b3f128ad91477743db1dc/setup.cfg#L51

maybe the conda forge bot isn't parsing this line correctly

@Xarthisius Xarthisius merged commit 8c58914 into conda-forge:main Oct 9, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 4.1.0_h0186f5 branch October 9, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants