Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs theme #784

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Update docs theme #784

merged 9 commits into from
Apr 10, 2024

Conversation

pavithraes
Copy link
Member

Fixes #764

Description

This pull request updates the documentation theme properties with the conda-store theme.

Currently, this is a draft PR to have a preview as we make updates.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Add @smeragoel as a co-author while merging.

How to test

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 908167e
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/661583446591150008110e96
😎 Deploy Preview https://deploy-preview-784--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: smeragoel <98317216+smeragoel@users.noreply.github.com>
@smeragoel
Copy link
Contributor

smeragoel commented Mar 18, 2024

I've made some color updates and currently, there are no accessibility issues detected, except for a minor one in the breadcrumbs. To address this, I recommend the following change:

From:
--ifm-breadcrumb-color-active: var(--ifm-color-primary);

To:
--ifm-breadcrumb-color-active: var(--ifm-color-primary-dark);

Also, I want to update the footer colour:
--ifm-footer-background-color: #242526;

I'm not entirely sure which file needs this adjustment, so I'm hoping you could help out with this, @pavithraes.

Once this change is implemented, I plan to do a final check to ensure everything is in order, and then we should be all set!

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pavithraes
Copy link
Member Author

@smeragoel - The changes you requested are done :)

@pavithraes pavithraes marked this pull request as ready for review March 22, 2024 15:52
@smeragoel
Copy link
Contributor

@pavithraes the netlify preview isn't working for me, could you help out?

@pavithraes
Copy link
Member Author

@smeragoel - Preview is available now :)

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link
Contributor

@smeragoel smeragoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There don't seem to be any major accessibility issues, however, I do think we could benefit from an a11y audit down the line.

@pavithraes pavithraes merged commit 47a02d9 into conda-incubator:main Apr 10, 2024
25 checks passed
@pavithraes pavithraes deleted the docs-theme branch April 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[DOC] Update documentation website theme
2 participants