[6 of #107] move installer detection logic to implementation #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2020
Open
goanpeca
reviewed
Dec 22, 2020
| ); | ||
| }, | ||
| installerPath: async (inputs, options) => { | ||
| // no-op |
There was a problem hiding this comment.
What does this mean @bollwyvl ?
There was a problem hiding this comment.
so with the bundled installer, we do nothing, as it's already installed... just update the options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the boolean logic for each installer provider out of
setupto its individual file. This 1) cuts down on the complexity insetup, and 2) makes it very tractable to add the next installer, e.g. MiniForge, etc.On the next PR
Apply a similar treatment as this PR to the running of an installer and creating the environment. Another large chunk of
setupwill drop, and the boolean switches will be closer to their specific implementations. This is where the hook would become relevant for whethermambais already provided by the installer for, e.g. config operations.