Remove * from valid version characters
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Jul 22, 2023
There was a problem hiding this comment.
Nice! Thanks for this @AntoinePrv ! 👍 🥇
It might also be worth mentioning that this behavior has already partially been deprecated in the use of VersionSpec in conda as mentioned here:
log.warning(
"Using .* with relational operator is superfluous and deprecated "
"and will be removed in a future version of conda. Your spec was "
"{}, but conda is ignoring the .* and treating it as {}".format(
vo_str, vo_str[:-2]
)
)
cep-xx.md
Outdated
Comment on lines
120
to
122
| This is the most delicate part to handle since ``>1.7*`` is frequently use to mean greater than the | ||
| ``1.7`` infimum (could also be writen as ``=1.7|>=1.7``, that is, mathching some versions smaller | ||
| than ``1.7.0``, such as ``1.7alpha``). |
There was a problem hiding this comment.
Existing cases here are often caused by someone accidentally using =>1.7* in a recipe instead of >=1.7*. I vote we should interpret it as what is most likely intended here (e.g. >=1.7*).
jaimergp
reviewed
Jul 24, 2023
jaimergp
reviewed
Aug 2, 2023
jaimergp
reviewed
Aug 2, 2023
|
Hi all, How can I move this forward? Is there a meeting I should attend to champion this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Rendered version
We recommend to remove
*from validVersioncharacters, due to confusing intersection withVersionSpecglob expressions.We suggest different possibilities on how the character could be reinterpreted in
VersionSpecwith an analysis on backward compatibility.