Refactor conda_build.build.get_all_replacements #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to make code readable and to remove duplicate logic.
anaconda-issue-bot
added
the
cla-signed
|
The debugging code is there because I suspect there is still a bug in here .. I'd like to defer merging this one or else I'll need to add debugging back to it, which isn't too bad.. |
|
Yeah, that's what I was suspecting when I saw how new the code was, no hard feelings if you reject this then :) |
|
It's no problem, I appreciate the help and will give this a proper review when I can. |
|
It is still plenty debuggable like this, thanks @njalerikson |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to make code readable and to remove duplicate logic. Also removed what appears to be debugging print statements that are no longer in use.