Allow directories as license_file source #4153
Conversation
anaconda-issue-bot
added
the
cla-signed
| if os.path.isdir(src_file) and not src_file.endswith("/"): | ||
| raise ValueError( | ||
| "License entry in about/license_file ({}) points to a directory but does not " | ||
| "end with a '/'. Make sure the directory only contains license files and " | ||
| "append a '/' to include the folder and all of its content as license " | ||
| "information.".format(src_file) | ||
| ) |
There was a problem hiding this comment.
This restriction can be removed whenever needed. I added it for now because it's easier to lift restrictions than to add them afterwards.
|
@mingwandroid, if you deem this change as not very controversial, it would be nice to slip it into the next release. |
|
I am fine with trying to get this into the next release. What do you think about the test failures? Not all are 404 errors, some look license related. |
|
The CI failures seem unrelated, though I'm working on fixes some at gh-4154 |
|
If CI from gh-4154 runs through successfully and it's merged, we can rebase this commit. |
mbargull
force-pushed
the
license_file-dir
branch
from
9d205fd to
c58a74f
Compare
Thanks!
Done and all green; ready to go :). |
|
Thanks again @mbargull |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Resolves #4121.