Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prelink_message files to the conda package #4203

Merged
merged 3 commits into from
May 19, 2021
Merged

Add prelink_message files to the conda package #4203

merged 3 commits into from
May 19, 2021

Conversation

marcelotrevisani
Copy link
Member

Related to conda/conda#10118

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 2, 2021
@marcelotrevisani
Copy link
Member Author

cc: @conda/conda-core

@chenghlee chenghlee self-requested a review March 3, 2021 16:24
chenghlee
chenghlee requested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should change the naming from eula to prelink_message? In the context of conda/conda#10118, EULAs will be a common, but not the only, use case for the feature.

@marcelotrevisani
Copy link
Member Author

Perhaps we should change the naming from eula to prelink_message? In the context of conda/conda#10118, EULAs will be a common, but not the only, use case for the feature.

Sure, no worries! I will make this change tomorrow, thanks for reviewing the PR :)

@marcelotrevisani marcelotrevisani changed the title Add eula files to the conda package Add prelink_message files to the conda package Mar 4, 2021
@marcelotrevisani
Copy link
Member Author

Perhaps we should change the naming from eula to prelink_message? In the context of conda/conda#10118, EULAs will be a common, but not the only, use case for the feature.

Done!

@marcelotrevisani
Copy link
Member Author

cc: @conda/conda-core

@marcelotrevisani
Copy link
Member Author

@chenghlee @ocefpaf
image

chenghlee
chenghlee approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but I/we need to figure out why the macOS CI checks are failing.

@marcelotrevisani
Copy link
Member Author

Code looks fine, but I/we need to figure out why the macOS CI checks are failing.

It was failing before, it is not related to this modification. But indeed it would be nice to take a look at it

@marcelotrevisani marcelotrevisani merged commit 379f04f into conda:master May 19, 2021
@marcelotrevisani marcelotrevisani deleted the conda-10118-eula branch May 19, 2021 17:48
@marcelotrevisani marcelotrevisani mentioned this pull request Jan 5, 2022
Merged
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenghlee chenghlee chenghlee approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelotrevisani @chenghlee @anaconda-issue-bot