support stdlib() jinja function #4996
Conversation
conda-bot
added
the
cla-signed
| # fall back to native if language-key is not explicitly set in variant | ||
| package_prefix = config.variant.get(language_key, package_prefix) |
There was a problem hiding this comment.
Not sure if the fallback makes sense for stdlib? If I read the code correctly, the fallback key we'd be looking for would just be c?
IOW, if I'm not overlooking something here, I think we could move move the if "compiler" branch in here rather than setting a dummy package_prefix for stdlib.
There was a problem hiding this comment.
Yes, it would be c_linux-64. We can also use {{ compiler('clang') }} which expands to clang_linux-64 with this fallback. Don't see a reason we shouldn't allow it for stdlib.
|
@h-vetinari, can you help with writing a test and fixing the existing tests? |
|
Do you want me to raise a PR against your branch or can you make me collaborator on your fork? |
|
Can you create a new PR in this repo? |
|
Done: #4999 |
|
Superseded by #4999 |
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Fixes #4981
cc @h-vetinari, @chenghlee, @mbargull, @beckermr