-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rpaths patcher being run on symbolic links #5181
Fix rpaths patcher being run on symbolic links #5181
Conversation
b804498
to
9a141c2
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
9a141c2
to
fc984b1
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
a04e512
to
b6d99fa
Compare
This currently targets
This bug is a bit problematic since it doesn't cause builds to outright fail, but rather leads to silently create partially broken packages.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow this was sneaky, I went back through the old PRs and agree that these are the old is_codefile
/codefile_type
calls
I'm in favor of doing another 24.1
patch, I'd prefer not to do another 3.28
unless we absolutely have to
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Indeed -- kind of fortunate that we ran into the
How about we merge this, release |
Description
Use
skip_symlinks=True
for formeris_codefile
/codefile_type
calls.This just mechanically adds
skip_symlinks=True
to the calls sides that previously had this implicitly (before 1dc2470).Fixes gh-5179 .
Checklist - did you ...
news
directory (using the template) for the next release's release notes?