Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate conda_build.api.get_output_file_path #5208

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

ryanskeith
Copy link
Contributor

@ryanskeith ryanskeith commented Mar 1, 2024

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@ryanskeith ryanskeith requested a review from a team as a code owner March 1, 2024 21:14
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 1, 2024
@beeankha
Copy link
Member

beeankha commented Mar 7, 2024

pre-commit.ci autofix

@ryanskeith
Copy link
Contributor Author

ryanskeith commented Mar 8, 2024

Do we feel okay with doing this deprecation without using the @deprecated function? @beeankha @kenodegard I feel we are ok as users have been warned for the last 6-7 years, but would be perfectly fine backtracking. The only internal use we have is for the tests. Everywhere else has been using the newer name.

@jezdez
Copy link
Member

jezdez commented Mar 8, 2024

@ryanskeith Let's go through the regular deprecation policy, the key is to follow the policy for risk of losing the overview of the special cases we've made along the way. A few more months for this won't be a problem compared to the years before ;)

@ryanskeith
Copy link
Contributor Author

Will do.

conda_build/api.py Outdated Show resolved Hide resolved
news/5208-deprecate-get_output_file_path Outdated Show resolved Hide resolved
@kenodegard kenodegard changed the title Removal deprecated function: get_output_file_path Deprecate conda_build.api.get_output_file_path Mar 8, 2024
@kenodegard kenodegard enabled auto-merge (squash) March 8, 2024 22:33
@kenodegard kenodegard merged commit 558f4da into conda:main Mar 8, 2024
27 checks passed
@beeankha beeankha mentioned this pull request Mar 12, 2024
32 tasks
@ryanskeith ryanskeith deleted the Remove-deprecated-function branch March 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants