Add command line option to specify the wanted package format #5209
+142
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5209 will not alter performanceComparing Summary
|
beeankha
reviewed
Nov 6, 2024
| @@ -58,7 +99,7 @@ def set_invocation_time(): | |||
| no_rewrite_stdout_env_default = "false" | |||
| ignore_verify_codes_default = [] | |||
| exit_on_verify_error_default = False | |||
| conda_pkg_format_default = None | |||
| conda_pkg_format_default = CondaPkgFormat.V1 | |||
There was a problem hiding this comment.
Suggested change
| conda_pkg_format_default = CondaPkgFormat.V1 | |
| conda_pkg_format_default = CondaPkgFormat.V2 |
There was a problem hiding this comment.
I think this change should be postponed to 25.1.
beeankha
reviewed
Nov 6, 2024
3 tasks
jaimergp
reviewed
Nov 7, 2024
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jezdez
changed the title
jezdez
previously approved these changes
Nov 7, 2024
jezdez
reviewed
Nov 7, 2024
dholth
reviewed
Nov 8, 2024
dholth
reviewed
Nov 8, 2024
|
Isn't there also an environment variable for this |
…ed value if it is not set to None
Co-authored-by: Daniel Holth <dholth@anaconda.com>
beeankha
approved these changes
Nov 8, 2024
jezdez
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #4890.
--package-formatintroduced as command line argumentChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?