Properly initialize context with parsed arguments #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5271 will not alter performanceComparing Summary
|
kenodegard
force-pushed
the
initialize-context
branch
from
c087f9a to
cc60222
Compare
kenodegard
commented
Apr 5, 2024
kenodegard
commented
Apr 5, 2024
beeankha
previously approved these changes
Apr 18, 2024
jezdez
previously approved these changes
Apr 18, 2024
| @@ -525,13 +525,14 @@ def check_action(recipe, config): | |||
|
|
|||
| def execute(args: Sequence[str] | None = None) -> int: | |||
| _, parsed = parse_args(args) | |||
| context.__init__(argparse_args=parsed) | |||
jezdez
approved these changes
Apr 18, 2024
beeankha
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
None of the conda-build commands are correctly initializing the
conda.base.context.contextobject with the parsed arguments. This means--override-channels(and other arguments) aren't properly detected.Another side effect of not setting the context object with the parsed arguments is conda-build's need to manually parse and handle the channels (search for
channel_urlsin the source code). It appears we can ignore this for the time being but this will need to be revisited soon.We also bump the minimum conda to
23.7.0(to benefit from conda/conda#12696).Resolves #3693
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?