-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report fully rendered recipe to stdout #5344
Conversation
CodSpeed Performance ReportMerging #5344 will not alter performanceComparing Summary
|
@@ -111,7 +111,7 @@ def setup(**kw): | |||
exec(code, ns, ns) | |||
else: | |||
if not permit_undefined_jinja: | |||
raise TypeError(f"{setup_file} is not a file that can be read") | |||
raise TypeError("%s is not a file that can be read" % setup_file) # noqa: UP031 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this old syntax because this module will be injected in the workdir to be executed by a potentially older Python (e.g. 3.5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this more like a ValueError or RuntimeError (or FileNotFoundError)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 I didn't put it there :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Closes #3798
Example output
Checklist - did you ...
news
directory (using the template) for the next release's release notes?