perf: only set level if needed #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5384 will not alter performanceComparing Summary
|
|
@minrk Can you test this approach? |
minrk
reviewed
Jun 21, 2024
|
Yeah, this gets ~90% of the savings in #5383. Thanks! |
beckermr
commented
Jun 21, 2024
jaimergp
previously approved these changes
Jun 25, 2024
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
|
Woops this needs another approval @jaimergp! |
kenodegard
approved these changes
Jun 25, 2024
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to address #5382 by only calling
setLevelif needed. I am trying it instead of #5383 since it is less intrusive and I am seeing odd test failures in that PR.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?closes #5383
closes #5382