Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses python version for poetry's pyproject.toml, always managed by conda #526

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Parses python version for poetry's pyproject.toml, always managed by conda #526

merged 1 commit into from
Oct 13, 2023

Conversation

pep-sanwer
Copy link
Contributor

This resolves the oversight uncovered at the tail end of Default PyPI dependencies for pyproject.toml #334.
Poetry's pyproject.toml python version is now parsed and always managed by conda (as it is not a dependency that can be managed by pip)

Added Poetry's required Python version (search declaring the python version) specification for all poetry pyproject.toml tests

TODO: implement for non-poetry pyproject.toml flavors (pdm, filt) - a bit complicated as they have differing implementations / locations for python version specification.

@pep-sanwer pep-sanwer requested a review from a team as a code owner October 12, 2023 21:48
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 85bb282
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65299d868c05880008e79f61
😎 Deploy Preview https://deploy-preview-526--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice and straightforward, thanks!!!

Could we add an assertion for assert specs["python"].version? Then I think we're good to go.

only impacts poetry's pyproject.toml
@pep-sanwer
Copy link
Contributor Author

@maresb requested changes in above force push! Thank you again for all your time!

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pep-sanwer!!!

@maresb maresb merged commit f628b51 into conda:main Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants