Simplify suffix_union function #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Attn @jacksmith15 |
maresb
force-pushed
the
simplify-suffix-union
branch
from
14deef0 to
f567e46
Compare
jacksmith15
reviewed
Oct 16, 2023
|
|
||
| result: List["SupportsRichComparisonT"] = [] | ||
|
|
||
| def prefix_union(collections: Iterable[Sequence]) -> List: |
There was a problem hiding this comment.
Seems an improvement to me!
I wonder if part of the confusion has stemmed from the generic naming of these functions.
Could it be instead called unify_package_sources or merge_package_sources?
FWIW the way I reason about this logic is a bit different, not sure if this is more or less confusing to others (probably a tad less performant):
def unify_package_sources(collections: Iterable[Sequence[str]]) -> List[str]:
result = max(collections, key=len)
for collection in collections:
if collection != result[-len(collection):]:
raise ValueError(f"{collection} is not an ordered subset of {result}")
return resultThere was a problem hiding this comment.
Nice!! I think there's an edge case when len(collection) == 0. But making sure that's in order, would you like to make a PR to supersede mine?
|
Superseded by #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #530. Let's see if the tests pass...