Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose failure #702

Closed
wants to merge 11 commits into from
Closed

Diagnose failure #702

wants to merge 11 commits into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Sep 14, 2024

Description

I'm seeing a really strange failure here in #701:
https://github.com/conda/conda-lock/actions/runs/10864882296/job/30151069068?pr=701

This name is much more explicit. Also add a doctest.
Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 66ab420
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/66e6f330cfa2a60008033af1
😎 Deploy Preview https://deploy-preview-702--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb maresb force-pushed the diagnose-failure branch 3 times, most recently from f456d79 to c9828d7 Compare September 15, 2024 12:25
Otherwise when we parse non-Poetry pyproject.toml, it always converts
PyPI names to conda names, even if the dep stays as PyPI.
This shouldn't make a difference, but it's probably very slightly safer this way.
This reverts commit f2c52fe.
This reverts commit b5f0f59b71dfe7fba6c44fd7d6df074cc562c37c.
@maresb
Copy link
Contributor Author

maresb commented Sep 15, 2024

Resolved in #703

@maresb maresb closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant