Add support for local sdist #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @beenje , sorry for my delay, my son was born last week and I didn't have much time to take a look on my notifications. I will review it now, thanks a lot! |
|
We had just one failing test that needed adjustment. I already fixed it to speed up the process so we can integrate that soon :) |
|
LGTM! 🎉 🎉 🎉 🎉 |
|
Thanks! |
|
Thanks! :) I already generated a new version and it should be on conda-forge in 30minutes or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to create recipe from local sdist.
I noticed some keys like
summarywere sometimes missing when parsing setup.cfg.I added parsing some keys from PKG-INFO using pkginfo.
Fix #272